Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma/redefining classnames for typography #950

Closed
wants to merge 5 commits into from
Closed

plasma/redefining classnames for typography #950

wants to merge 5 commits into from

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Dec 25, 2023 •
edited by Salute-Eva
Loading

Typography

  • className, style теперь явно задаются в компоненте

What/why changed

Если типографику обернуть в styled из styled-components, слетали классы и инлайн-стили. Теперь className, style достаются как пропсы и складываются в соответствующие атрибуты

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich added the bugs Something isn't working label Dec 25, 2023
@TitanKuzmich TitanKuzmich self-assigned this Dec 25, 2023
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-950/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-950/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-950/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-950/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-950/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-950/asdk-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich
Copy link
Contributor Author

Будет сделано в другом пр

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeti-or Yeti-or Awaiting requested review from Yeti-or Yeti-or is a code owner

@neretin-trike neretin-trike Awaiting requested review from neretin-trike neretin-trike is a code owner

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

@kayman233 kayman233 Awaiting requested review from kayman233

Assignees

@TitanKuzmich TitanKuzmich

Labels
bugs Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TitanKuzmich @Salute-Eva