Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plasma-core): Add new prop (scrollSnapStop) to the Carousel component #940

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

shuga2704
Copy link
Contributor

@shuga2704 shuga2704 commented Dec 21, 2023

Carousel

  • добавлен пропс scrollSnapStop в Carousel

What/why changed

Добавлено св-во scrollSnapStop в core/CarouselItem, которое по дефолту делает скролл в карусели по одному слайду. Не влияет на десктопы.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-940/

@shuga2704 shuga2704 self-assigned this Dec 21, 2023
@shuga2704 shuga2704 marked this pull request as ready for review December 21, 2023 10:42
@shuga2704 shuga2704 requested review from TitanKuzmich and removed request for Yeti-or and Yakutoc December 21, 2023 10:43
@kayman233
Copy link
Contributor

Можешь еще плиз добавить в сторибуке аргументы для пропсов с scrollSnap?
А то кажется сейчас не посмотреть, как они работают

@shuga2704
Copy link
Contributor Author

Можешь еще плиз добавить в сторибуке аргументы для пропсов с scrollSnap? А то кажется сейчас не посмотреть, как они работают

В сторибуке как оказалось этот функционал вообще не работает. Я уже завел другую таску под это дело и в ней профикшу этот момент.

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-940/

@TitanKuzmich
Copy link
Contributor

Переименую последний коммит в feat(plasma-core)...
chore как правило не может быть последним коммитом из-за особенностей с пайпланами

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-940/

@shuga2704 shuga2704 added this pull request to the merge queue Dec 27, 2023
Merged via the queue into dev with commit 9d6d576 Dec 27, 2023
27 checks passed
@shuga2704 shuga2704 deleted the plasma-2268 branch December 27, 2023 08:18
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants