plasma-new-hope: Notification redesign #927

kayman233 · 2023-12-14T14:19:10Z

Notification

добавлен новый дизайн компонента
добавили новый api

Было:

Стало:

What/why changed

Добавлены иконки, кнопки для взаимодействия, а также 2 вида layout - горизонтальный и вертикальный

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Salute-Eva · 2023-12-14T14:21:38Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-927/

Salute-Eva · 2023-12-14T14:33:46Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-927/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-927/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-927/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-927/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-927/asdk-storybook/

Salute-Eva · 2023-12-14T14:36:41Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-927/

Salute-Eva · 2023-12-14T14:44:59Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-927/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-927/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-927/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-927/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-927/asdk-storybook/

github-actions · 2023-12-14T15:10:17Z

⚡ Component performance testing

Result: 🟢 OK

packages/plasma-new-hope/src/components/Notification/utils/index.ts

Yakutoc · 2023-12-15T05:13:35Z

packages/plasma-new-hope/src/examples/plasma_b2c/components/Notification/Notification.tsx


 export const NotificationsProvider: React.FC<{ children: ReactNode; frame?: string }> = ({
    children,
-    frame = 'theme-root',
+    frame = 'document',


[Уточнени]

А объясни пожалуйста тезисно как теперь работает.

это я забыл убрать, пока тестил. Спасибо, что заметил

Yakutoc · 2023-12-15T05:22:06Z

packages/plasma-new-hope/src/components/Notification/Notification.types.ts

+     */
+    actions?: ReactNode;
+    /**
+     * Тип направления расположения всех частей Notification.


Комментарий и название prop как мне кажется немного про разное.

Может - "схема расположение блоков Notification" ?

Да, так получше звучит, как ты предложил

Yakutoc · 2023-12-15T05:24:05Z

packages/plasma-new-hope/src/components/Notification/Notification.styles.ts

+    &.${classes.horizontal} {
+        display: flex;
+        align-items: center;
+        flex: 1;


[Уточнение]

Это сокращение - и тут значение 1 для: flex-shrink, flex-base, flex-grow.

Это так и задумывалось?

вообще flex-grow

Salute-Eva · 2023-12-15T08:18:08Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-927/

Salute-Eva · 2023-12-18T15:27:53Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-927/

Salute-Eva · 2023-12-18T15:34:57Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-927/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-927/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-927/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-927/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-927/asdk-storybook/

github-actions · 2023-12-18T15:44:45Z

⚡ Component performance testing

Result: 🟢 OK

Salute-Eva · 2023-12-19T09:12:25Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-927/

Salute-Eva · 2023-12-19T09:19:45Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-927/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-927/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-927/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-927/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-927/asdk-storybook/

github-actions · 2023-12-19T09:29:08Z

⚡ Component performance testing

Result: 🟢 OK

Salute-Eva · 2023-12-19T09:42:15Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-12-19T09:42:17Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-12-22T07:26:12Z

kayman233 added the plasma-components label Dec 14, 2023

kayman233 temporarily deployed to internal December 14, 2023 14:19 — with GitHub Actions Inactive

kayman233 force-pushed the kayman233/notification-redesign.PLASMA-2235 branch from c0553a3 to 77a111a Compare December 14, 2023 14:34

kayman233 temporarily deployed to internal December 14, 2023 14:34 — with GitHub Actions Inactive

kayman233 marked this pull request as ready for review December 14, 2023 14:34

kayman233 requested review from Yeti-or, neretin-trike and Yakutoc as code owners December 14, 2023 14:34

Yakutoc reviewed Dec 15, 2023

View reviewed changes

packages/plasma-new-hope/src/components/Notification/utils/index.ts Outdated Show resolved Hide resolved

Yakutoc reviewed Dec 15, 2023

View reviewed changes

Yeti-or requested a review from a team December 15, 2023 07:49

kayman233 force-pushed the kayman233/notification-redesign.PLASMA-2235 branch from 77a111a to 133d3c5 Compare December 15, 2023 08:15

kayman233 temporarily deployed to internal December 15, 2023 08:15 — with GitHub Actions Inactive

kayman233 temporarily deployed to internal December 18, 2023 15:25 — with GitHub Actions Inactive

neretin-trike approved these changes Dec 19, 2023

View reviewed changes

kayman233 added 3 commits December 19, 2023 11:43

feat(plasma-new-hope): Notification redesign

179c6fe

feat(plasma-web, plasma-b2c): redesign Notification

bd26bd2

fix(plasma-new-hope): fix Notification layout with long text

f566aea

kayman233 force-pushed the kayman233/notification-redesign.PLASMA-2235 branch from 5048e82 to f566aea Compare December 19, 2023 09:09

kayman233 temporarily deployed to internal December 19, 2023 09:09 — with GitHub Actions Inactive

kayman233 added this pull request to the merge queue Dec 19, 2023

Merged via the queue into dev with commit 6ddc660 Dec 19, 2023
25 checks passed

kayman233 deleted the kayman233/notification-redesign.PLASMA-2235 branch December 19, 2023 09:31

Salute-Eva added the prerelease label Dec 19, 2023

This was referenced Dec 22, 2023

Release by 22.12.2023 #943

Closed

Release by 22.12.2023 #944

Merged

Yakutoc mentioned this pull request Dec 22, 2023

Release by 22.12.2023 #945

Merged

Salute-Eva added released and removed prerelease labels Dec 22, 2023

Salute-Eva mentioned this pull request Jan 18, 2024

Release by 18.01.2024 #972

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plasma-new-hope: Notification redesign #927

plasma-new-hope: Notification redesign #927

kayman233 commented Dec 14, 2023 •

edited by Salute-Eva

Loading

Salute-Eva commented Dec 14, 2023

Salute-Eva commented Dec 14, 2023

Salute-Eva commented Dec 14, 2023

Salute-Eva commented Dec 14, 2023

github-actions bot commented Dec 14, 2023

Yakutoc Dec 15, 2023

kayman233 Dec 15, 2023

Yakutoc Dec 15, 2023

kayman233 Dec 15, 2023

Yakutoc Dec 15, 2023

kayman233 Dec 15, 2023

Salute-Eva commented Dec 15, 2023

Salute-Eva commented Dec 18, 2023

Salute-Eva commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

github-actions bot commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 22, 2023

plasma-new-hope: Notification redesign #927

plasma-new-hope: Notification redesign #927

Conversation

kayman233 commented Dec 14, 2023 • edited by Salute-Eva Loading

Notification

What/why changed

Salute-Eva commented Dec 14, 2023

Salute-Eva commented Dec 14, 2023

Salute-Eva commented Dec 14, 2023

Salute-Eva commented Dec 14, 2023

github-actions bot commented Dec 14, 2023

⚡ Component performance testing

Yakutoc Dec 15, 2023

Choose a reason for hiding this comment

kayman233 Dec 15, 2023

Choose a reason for hiding this comment

Yakutoc Dec 15, 2023

Choose a reason for hiding this comment

kayman233 Dec 15, 2023

Choose a reason for hiding this comment

Yakutoc Dec 15, 2023

Choose a reason for hiding this comment

kayman233 Dec 15, 2023

Choose a reason for hiding this comment

Salute-Eva commented Dec 15, 2023

Salute-Eva commented Dec 18, 2023

Salute-Eva commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

⚡ Component performance testing

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

github-actions bot commented Dec 19, 2023

⚡ Component performance testing

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 19, 2023

Salute-Eva commented Dec 22, 2023

kayman233 commented Dec 14, 2023 •

edited by Salute-Eva

Loading