Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-infra: Run cypress with --components #907

Merged
merged 2 commits into from
Dec 19, 2023
Merged

plasma-infra: Run cypress with --components #907

merged 2 commits into from
Dec 19, 2023

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Dec 12, 2023 •
edited
Loading

Cypress

  • добавлена возможность запустить тест для перечисленных компонентов

Запуск команды "npm run cy:web:run-ct --components='calendar,button'" даст

Screenshot 2023-12-12 at 15 57 08

What/why changed

Для ускорения локальной разработки, была добавлена возможность указать для каких компонентов нужно запустить тесты.

Теперь команды

  • cy:{package}:run-ct
  • cy:{package}:run-ct-update-diffs

понимают аргумент --components='comp1, comp2'

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc self-assigned this Dec 12, 2023
@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-907/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-907/b2c-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc force-pushed the chore-cypress-local branch from 8c12ba4 to a218c66 Compare December 12, 2023 09:30
@salute-developers salute-developers deleted a comment from Salute-Eva Dec 12, 2023
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-907/

@Yakutoc Yakutoc marked this pull request as ready for review December 12, 2023 09:41
@Yakutoc Yakutoc requested review from TitanKuzmich and removed request for neretin-trike December 12, 2023 09:41
@Yakutoc Yakutoc force-pushed the chore-cypress-local branch from a218c66 to f82dc61 Compare December 14, 2023 07:28
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-907/

kayman233
kayman233 approved these changes Dec 14, 2023
View reviewed changes
cypress/cypress-get-specs.js Show resolved Hide resolved
@Yakutoc Yakutoc force-pushed the chore-cypress-local branch from f82dc61 to 7a139bc Compare December 18, 2023 05:59
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-907/

@Yakutoc Yakutoc force-pushed the chore-cypress-local branch from 7a139bc to 6b85547 Compare December 18, 2023 06:16
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-907/

Yeti-or
Yeti-or approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@Yeti-or Yeti-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

только поменяй заголово pr на --components
и наверно это надо в Contribution.md добавить

@Yakutoc Yakutoc changed the title plasma-infra: Run cypress with --spec plasma-infra: Run cypress with --components Dec 19, 2023
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-907/

@Yakutoc Yakutoc added this pull request to the merge queue Dec 19, 2023
Merged via the queue into dev with commit 40a64e7 Dec 19, 2023
23 checks passed
@Yakutoc Yakutoc deleted the chore-cypress-local branch December 19, 2023 04:53
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

This was referenced Dec 22, 2023
Closed
Merged
@Yakutoc Yakutoc mentioned this pull request Dec 22, 2023
Merged
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva Salute-Eva mentioned this pull request Jan 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayman233 kayman233 kayman233 approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

Assignees

@Yakutoc Yakutoc

Labels
plasma-infra released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yakutoc @Salute-Eva @Yeti-or @neretin-trike @TitanKuzmich @kayman233