fix(plasma-theme-builder): Add restored color method for generate themes #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neretin-trike
requested review from
Yeti-or,
Yakutoc and
kayman233
as code owners
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
force-pushed
the
neretinaa/theme-builder-add-restored-color
branch
from
1fbd087 to
a7f1fa4
Compare
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
neretin-trike
temporarily deployed
to
internal
GitHub Actions
Inactive
kayman233
approved these changes
Dec 11, 2023
Yakutoc
force-pushed
the
neretinaa/theme-builder-add-restored-color
branch
from
a7f1fa4 to
381cda2
Compare
Yakutoc
reviewed
Dec 13, 2023
| @@ -57,7 +58,7 @@ export const getThemes = async ( | |||
| ) => { | |||
| const pathToIndex = getFilesPath().themesIndex; | |||
| const tokensThemeIndex = await getFilesSource(undefined, owner, repo, pathToIndex, defaultBranch); | |||
| const themes = generateThemes(tokensSet, undefined, true); | |||
| const themes = generateThemes(tokensSet, undefined, true, true); | |||
There was a problem hiding this comment.
[На будущее]
@neretin-trike Похоже на то что сигнатуру метода надо будет перевести в объект. Сейчас сложно понять за что отвечают эти аргументы.
Yakutoc
approved these changes
Dec 13, 2023
Yakutoc
force-pushed
the
neretinaa/theme-builder-add-restored-color
branch
from
381cda2 to
0337f8e
Compare
This was referenced Dec 14, 2023
Closed
Closed
Merged
|
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theme builder
What/why changed
Изменения необходимы, т.к. иначе при генерации новой схемы в файлах темы будут корректные значения (ссылки)