plasma-(new-hope, asdk): Add focus mixin #888

TitanKuzmich · 2023-12-04T17:02:05Z

AddFocus

добавлен общий mixin addFocus(на него переведены компоненты: Chip, Checkbox, Radiobox, Calendar )

What/why changed

Этот mixin позволил избавиться от дублирования кода.

🐤 Download canary assets:

borderRadius

borderRadius_default_react-native--canary.888.7091553141.ts
borderRadius_plasma_b2c_react-native--canary.888.7091553141.ts
borderRadius_plasma_web_react-native--canary.888.7091553141.ts
borderRadius_sberHealth_react-native--canary.888.7091553141.ts
borderRadius_sbermarket_business_react-native--canary.888.7091553141.ts
borderRadius_sbermarket_metro_react-native--canary.888.7091553141.ts
borderRadius_sbermarket_react-native--canary.888.7091553141.ts
borderRadius_sbermarket_selgros_react-native--canary.888.7091553141.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.888.7091553141.ts
borderRadius_sberonline_react-native--canary.888.7091553141.ts
borderRadius_sberprime_react-native--canary.888.7091553141.ts
borderRadius_stylesSalute_react-native--canary.888.7091553141.ts

color

color_default_ios-swift--canary.888.7091553141.swift
color_default_kotlin--canary.888.7091553141.kt
color_default_react-native--canary.888.7091553141.ts
color_default_xml--canary.888.7091553141.xml
color_plasma_b2c_ios-swift--canary.888.7091553141.swift
color_plasma_b2c_kotlin--canary.888.7091553141.kt
color_plasma_b2c_react-native--canary.888.7091553141.ts
color_plasma_b2c_xml--canary.888.7091553141.xml
color_plasma_web_ios-swift--canary.888.7091553141.swift
color_plasma_web_kotlin--canary.888.7091553141.kt
color_plasma_web_react-native--canary.888.7091553141.ts
color_plasma_web_xml--canary.888.7091553141.xml
color_sberHealth_ios-swift--canary.888.7091553141.swift
color_sberHealth_kotlin--canary.888.7091553141.kt
color_sberHealth_react-native--canary.888.7091553141.ts
color_sberHealth_xml--canary.888.7091553141.xml
color_sbermarket_business_ios-swift--canary.888.7091553141.swift
color_sbermarket_business_kotlin--canary.888.7091553141.kt
color_sbermarket_business_react-native--canary.888.7091553141.ts
color_sbermarket_business_xml--canary.888.7091553141.xml
color_sbermarket_ios-swift--canary.888.7091553141.swift
color_sbermarket_kotlin--canary.888.7091553141.kt
color_sbermarket_metro_ios-swift--canary.888.7091553141.swift
color_sbermarket_metro_kotlin--canary.888.7091553141.kt
color_sbermarket_metro_react-native--canary.888.7091553141.ts
color_sbermarket_metro_xml--canary.888.7091553141.xml
color_sbermarket_react-native--canary.888.7091553141.ts
color_sbermarket_selgros_ios-swift--canary.888.7091553141.swift
color_sbermarket_selgros_kotlin--canary.888.7091553141.kt
color_sbermarket_selgros_react-native--canary.888.7091553141.ts
color_sbermarket_selgros_xml--canary.888.7091553141.xml
color_sbermarket_wlbusiness_ios-swift--canary.888.7091553141.swift
color_sbermarket_wlbusiness_kotlin--canary.888.7091553141.kt
color_sbermarket_wlbusiness_react-native--canary.888.7091553141.ts
color_sbermarket_wlbusiness_xml--canary.888.7091553141.xml
color_sbermarket_xml--canary.888.7091553141.xml
color_sberonline_ios-swift--canary.888.7091553141.swift
color_sberonline_kotlin--canary.888.7091553141.kt
color_sberonline_react-native--canary.888.7091553141.ts
color_sberonline_xml--canary.888.7091553141.xml
color_sberprime_ios-swift--canary.888.7091553141.swift
color_sberprime_kotlin--canary.888.7091553141.kt
color_sberprime_react-native--canary.888.7091553141.ts
color_sberprime_xml--canary.888.7091553141.xml
color_stylesSalute_ios-swift--canary.888.7091553141.swift
color_stylesSalute_kotlin--canary.888.7091553141.kt
color_stylesSalute_react-native--canary.888.7091553141.ts
color_stylesSalute_xml--canary.888.7091553141.xml

shadow

shadow_default_react-native--canary.888.7091553141.ts
shadow_plasma_b2c_react-native--canary.888.7091553141.ts
shadow_plasma_web_react-native--canary.888.7091553141.ts
shadow_sberHealth_react-native--canary.888.7091553141.ts
shadow_sbermarket_business_react-native--canary.888.7091553141.ts
shadow_sbermarket_metro_react-native--canary.888.7091553141.ts
shadow_sbermarket_react-native--canary.888.7091553141.ts
shadow_sbermarket_selgros_react-native--canary.888.7091553141.ts
shadow_sbermarket_wlbusiness_react-native--canary.888.7091553141.ts
shadow_sberonline_react-native--canary.888.7091553141.ts
shadow_sberprime_react-native--canary.888.7091553141.ts
shadow_stylesSalute_react-native--canary.888.7091553141.ts

spacing

spacing_default_react-native--canary.888.7091553141.ts
spacing_plasma_b2c_react-native--canary.888.7091553141.ts
spacing_plasma_web_react-native--canary.888.7091553141.ts
spacing_sberHealth_react-native--canary.888.7091553141.ts
spacing_sbermarket_business_react-native--canary.888.7091553141.ts
spacing_sbermarket_metro_react-native--canary.888.7091553141.ts
spacing_sbermarket_react-native--canary.888.7091553141.ts
spacing_sbermarket_selgros_react-native--canary.888.7091553141.ts
spacing_sbermarket_wlbusiness_react-native--canary.888.7091553141.ts
spacing_sberonline_react-native--canary.888.7091553141.ts
spacing_sberprime_react-native--canary.888.7091553141.ts
spacing_stylesSalute_react-native--canary.888.7091553141.ts

typo

typo_mage_ios-swift--canary.888.7091553141.swift
typo_mage_kotlin--canary.888.7091553141.kt
typo_mage_react-native--canary.888.7091553141.ts
typo_plasma_ios-swift--canary.888.7091553141.swift
typo_plasma_kotlin--canary.888.7091553141.kt
typo_plasma_react-native--canary.888.7091553141.ts
typo_ruler_ios-swift--canary.888.7091553141.swift
typo_ruler_kotlin--canary.888.7091553141.kt
typo_ruler_react-native--canary.888.7091553141.ts
typo_sage_ios-swift--canary.888.7091553141.swift
typo_sage_kotlin--canary.888.7091553141.kt
typo_sage_react-native--canary.888.7091553141.ts
typo_sbermarket_ios-swift--canary.888.7091553141.swift
typo_sbermarket_kotlin--canary.888.7091553141.kt
typo_sbermarket_react-native--canary.888.7091553141.ts
typo_soulmate_ios-swift--canary.888.7091553141.swift
typo_soulmate_kotlin--canary.888.7091553141.kt
typo_soulmate_react-native--canary.888.7091553141.ts

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Salute-Eva · 2023-12-04T17:04:31Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-888/

Salute-Eva · 2023-12-04T17:14:41Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-888/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-888/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-888/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-888/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-888/asdk-storybook/

Salute-Eva · 2023-12-04T19:29:36Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-888/

Salute-Eva · 2023-12-04T19:35:52Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-888/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-888/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-888/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-888/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-888/asdk-storybook/

Yakutoc · 2023-12-06T06:44:15Z

[Душный режим on]

Заголовок для PR поменяй пожалуйста на что-то более читаемое, типа plasma-new-hope: Add focus mixin =)
Добавь еще мотивационную часть - почему добавили?

[Душный режим off]

Yeti-or

🚢

Salute-Eva · 2023-12-08T13:47:35Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-12-08T13:47:38Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-12-08T13:47:41Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-12-08T13:47:44Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-12-08T13:47:47Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Salute-Eva · 2023-12-14T06:36:07Z

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

TitanKuzmich requested review from Yeti-or, neretin-trike, Yakutoc and kayman233 as code owners December 4, 2023 17:02

TitanKuzmich temporarily deployed to internal December 4, 2023 17:02 — with GitHub Actions Inactive

TitanKuzmich removed request for Yakutoc and kayman233 December 4, 2023 17:02

TitanKuzmich self-assigned this Dec 4, 2023

TitanKuzmich added the new-hope label Dec 4, 2023

TitanKuzmich added this to the Plasma: Refactoring & Redesign milestone Dec 4, 2023

TitanKuzmich temporarily deployed to internal December 4, 2023 19:27 — with GitHub Actions Inactive

Yakutoc force-pushed the dev branch from 228a0ff to fe59d0d Compare December 5, 2023 04:36

TitanKuzmich changed the title ~~Plasma 2242/add focus mixin~~ feat(plasma-new-hope/asdk): add focus mixin Dec 6, 2023

TitanKuzmich added 6 commits December 7, 2023 03:37

feat(plasma-new-hope): add general addFocusMixin

56436e5

feat(plasma-new-hope): replace local addFocus on general

7aa9e25

feat(plasma-new-hope): replace local addFocus on general in radiobox

289b154

feat(plasma-new-hope): replace local addFocus on general in chip

8b98bdf

feat(plasma-asdk): reexport addFocus from new-hope

a08c53d

feat(plasma-new-hope): replace local addFocus on general in calendar

c4163a8

Yeti-or approved these changes Dec 8, 2023

View reviewed changes

TitanKuzmich added this pull request to the merge queue Dec 8, 2023

Merged via the queue into dev with commit 3b2c584 Dec 8, 2023
25 checks passed

TitanKuzmich deleted the plasma-2242/add-focus-mixin branch December 8, 2023 13:35

Salute-Eva added the prerelease label Dec 8, 2023

Salute-Eva mentioned this pull request Dec 13, 2023

Release by 13.12.2023 #911

Closed

Yakutoc added plasma-components and removed new-hope labels Dec 13, 2023

Salute-Eva mentioned this pull request Dec 13, 2023

Release by 13.12.2023 #912

Closed

Yakutoc changed the title ~~feat(plasma-new-hope/asdk): add focus mixin~~ plasma-(new-hope, asdk): Add focus mixin Dec 13, 2023

Salute-Eva added released and removed prerelease labels Dec 14, 2023

Salute-Eva mentioned this pull request Jan 18, 2024

Release by 18.01.2024 #972

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plasma-(new-hope, asdk): Add focus mixin #888

plasma-(new-hope, asdk): Add focus mixin #888

TitanKuzmich commented Dec 4, 2023 •

edited by Yakutoc

Loading

Salute-Eva commented Dec 4, 2023

Salute-Eva commented Dec 4, 2023

Salute-Eva commented Dec 4, 2023

Salute-Eva commented Dec 4, 2023

Yakutoc commented Dec 6, 2023 •

edited

Loading

Yeti-or left a comment

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 14, 2023

plasma-(new-hope, asdk): Add focus mixin #888

plasma-(new-hope, asdk): Add focus mixin #888

Conversation

TitanKuzmich commented Dec 4, 2023 • edited by Yakutoc Loading

AddFocus

What/why changed

Salute-Eva commented Dec 4, 2023

Salute-Eva commented Dec 4, 2023

Salute-Eva commented Dec 4, 2023

Salute-Eva commented Dec 4, 2023

Yakutoc commented Dec 6, 2023 • edited Loading

Yeti-or left a comment

Choose a reason for hiding this comment

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 8, 2023

Salute-Eva commented Dec 14, 2023

TitanKuzmich commented Dec 4, 2023 •

edited by Yakutoc

Loading

Yakutoc commented Dec 6, 2023 •

edited

Loading