Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma-infra(new-hope): Use @types/[email protected] #865

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Nov 22, 2023

Release Notes

Установили версию @types/[email protected] как и во всех остальных пользовательских пакетах.

What/why Changed

До этого использовалась версия 5.1.26 и это вызывало ошибку для метода applySpacing из-за разночтения api в styled-components

🐤 Download canary assets:
borderRadius
borderRadius_default_react-native--canary.865.6955865239.ts
borderRadius_plasma_b2c_react-native--canary.865.6955865239.ts
borderRadius_plasma_web_react-native--canary.865.6955865239.ts
borderRadius_sberHealth_react-native--canary.865.6955865239.ts
borderRadius_sbermarket_business_react-native--canary.865.6955865239.ts
borderRadius_sbermarket_metro_react-native--canary.865.6955865239.ts
borderRadius_sbermarket_react-native--canary.865.6955865239.ts
borderRadius_sbermarket_selgros_react-native--canary.865.6955865239.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.865.6955865239.ts
borderRadius_sberonline_react-native--canary.865.6955865239.ts
borderRadius_sberprime_react-native--canary.865.6955865239.ts
borderRadius_stylesSalute_react-native--canary.865.6955865239.ts
color
color_default_ios-swift--canary.865.6955865239.swift
color_default_kotlin--canary.865.6955865239.kt
color_default_react-native--canary.865.6955865239.ts
color_default_xml--canary.865.6955865239.xml
color_plasma_b2c_ios-swift--canary.865.6955865239.swift
color_plasma_b2c_kotlin--canary.865.6955865239.kt
color_plasma_b2c_react-native--canary.865.6955865239.ts
color_plasma_b2c_xml--canary.865.6955865239.xml
color_plasma_web_ios-swift--canary.865.6955865239.swift
color_plasma_web_kotlin--canary.865.6955865239.kt
color_plasma_web_react-native--canary.865.6955865239.ts
color_plasma_web_xml--canary.865.6955865239.xml
color_sberHealth_ios-swift--canary.865.6955865239.swift
color_sberHealth_kotlin--canary.865.6955865239.kt
color_sberHealth_react-native--canary.865.6955865239.ts
color_sberHealth_xml--canary.865.6955865239.xml
color_sbermarket_business_ios-swift--canary.865.6955865239.swift
color_sbermarket_business_kotlin--canary.865.6955865239.kt
color_sbermarket_business_react-native--canary.865.6955865239.ts
color_sbermarket_business_xml--canary.865.6955865239.xml
color_sbermarket_ios-swift--canary.865.6955865239.swift
color_sbermarket_kotlin--canary.865.6955865239.kt
color_sbermarket_metro_ios-swift--canary.865.6955865239.swift
color_sbermarket_metro_kotlin--canary.865.6955865239.kt
color_sbermarket_metro_react-native--canary.865.6955865239.ts
color_sbermarket_metro_xml--canary.865.6955865239.xml
color_sbermarket_react-native--canary.865.6955865239.ts
color_sbermarket_selgros_ios-swift--canary.865.6955865239.swift
color_sbermarket_selgros_kotlin--canary.865.6955865239.kt
color_sbermarket_selgros_react-native--canary.865.6955865239.ts
color_sbermarket_selgros_xml--canary.865.6955865239.xml
color_sbermarket_wlbusiness_ios-swift--canary.865.6955865239.swift
color_sbermarket_wlbusiness_kotlin--canary.865.6955865239.kt
color_sbermarket_wlbusiness_react-native--canary.865.6955865239.ts
color_sbermarket_wlbusiness_xml--canary.865.6955865239.xml
color_sbermarket_xml--canary.865.6955865239.xml
color_sberonline_ios-swift--canary.865.6955865239.swift
color_sberonline_kotlin--canary.865.6955865239.kt
color_sberonline_react-native--canary.865.6955865239.ts
color_sberonline_xml--canary.865.6955865239.xml
color_sberprime_ios-swift--canary.865.6955865239.swift
color_sberprime_kotlin--canary.865.6955865239.kt
color_sberprime_react-native--canary.865.6955865239.ts
color_sberprime_xml--canary.865.6955865239.xml
color_stylesSalute_ios-swift--canary.865.6955865239.swift
color_stylesSalute_kotlin--canary.865.6955865239.kt
color_stylesSalute_react-native--canary.865.6955865239.ts
color_stylesSalute_xml--canary.865.6955865239.xml
shadow
shadow_default_react-native--canary.865.6955865239.ts
shadow_plasma_b2c_react-native--canary.865.6955865239.ts
shadow_plasma_web_react-native--canary.865.6955865239.ts
shadow_sberHealth_react-native--canary.865.6955865239.ts
shadow_sbermarket_business_react-native--canary.865.6955865239.ts
shadow_sbermarket_metro_react-native--canary.865.6955865239.ts
shadow_sbermarket_react-native--canary.865.6955865239.ts
shadow_sbermarket_selgros_react-native--canary.865.6955865239.ts
shadow_sbermarket_wlbusiness_react-native--canary.865.6955865239.ts
shadow_sberonline_react-native--canary.865.6955865239.ts
shadow_sberprime_react-native--canary.865.6955865239.ts
shadow_stylesSalute_react-native--canary.865.6955865239.ts
spacing
spacing_default_react-native--canary.865.6955865239.ts
spacing_plasma_b2c_react-native--canary.865.6955865239.ts
spacing_plasma_web_react-native--canary.865.6955865239.ts
spacing_sberHealth_react-native--canary.865.6955865239.ts
spacing_sbermarket_business_react-native--canary.865.6955865239.ts
spacing_sbermarket_metro_react-native--canary.865.6955865239.ts
spacing_sbermarket_react-native--canary.865.6955865239.ts
spacing_sbermarket_selgros_react-native--canary.865.6955865239.ts
spacing_sbermarket_wlbusiness_react-native--canary.865.6955865239.ts
spacing_sberonline_react-native--canary.865.6955865239.ts
spacing_sberprime_react-native--canary.865.6955865239.ts
spacing_stylesSalute_react-native--canary.865.6955865239.ts
typo
typo_mage_ios-swift--canary.865.6955865239.swift
typo_mage_kotlin--canary.865.6955865239.kt
typo_mage_react-native--canary.865.6955865239.ts
typo_plasma_ios-swift--canary.865.6955865239.swift
typo_plasma_kotlin--canary.865.6955865239.kt
typo_plasma_react-native--canary.865.6955865239.ts
typo_ruler_ios-swift--canary.865.6955865239.swift
typo_ruler_kotlin--canary.865.6955865239.kt
typo_ruler_react-native--canary.865.6955865239.ts
typo_sage_ios-swift--canary.865.6955865239.swift
typo_sage_kotlin--canary.865.6955865239.kt
typo_sage_react-native--canary.865.6955865239.ts
typo_sbermarket_ios-swift--canary.865.6955865239.swift
typo_sbermarket_kotlin--canary.865.6955865239.kt
typo_sbermarket_react-native--canary.865.6955865239.ts
typo_soulmate_ios-swift--canary.865.6955865239.swift
typo_soulmate_kotlin--canary.865.6955865239.kt
typo_soulmate_react-native--canary.865.6955865239.ts
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

The entire project uses these versions

@types/styled-components: 5.1.0
styled-components": 5.3.1
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-865/

@Salute-Eva
Copy link
Contributor

@Yakutoc Yakutoc marked this pull request as ready for review November 22, 2023 10:32
@Yakutoc Yakutoc removed the request for review from neretin-trike November 22, 2023 10:32
@Yakutoc Yakutoc added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit 3277051 Nov 22, 2023
26 checks passed
@Yakutoc Yakutoc deleted the chore-new-hope-fix-styled-version branch November 22, 2023 11:06
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants