Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma-ASDK: Add new package "ASDK" #835

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Nov 8, 2023

Release Notes

Plasma-asdk:

  • Поднят storybook
  • Опубликован npm пакет
  • Обновлена/добавлнена Typography (в виде компонентов как старого, так и нового формата)
  • Добавлены компоненты: Button, Checkbox, Link, Radiobox, Spinner

Plasma-new-hope:

Добавлена типографика в виде компонент как старой, так и новой типографики, а так же в виде mixins.


🐤 Download canary assets:
borderRadius
borderRadius_default_react-native--canary.835.6822826221.ts
borderRadius_plasma_b2c_react-native--canary.835.6822826221.ts
borderRadius_plasma_web_react-native--canary.835.6822826221.ts
borderRadius_sberHealth_react-native--canary.835.6822826221.ts
borderRadius_sbermarket_business_react-native--canary.835.6822826221.ts
borderRadius_sbermarket_metro_react-native--canary.835.6822826221.ts
borderRadius_sbermarket_react-native--canary.835.6822826221.ts
borderRadius_sbermarket_selgros_react-native--canary.835.6822826221.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.835.6822826221.ts
borderRadius_sberonline_react-native--canary.835.6822826221.ts
borderRadius_sberprime_react-native--canary.835.6822826221.ts
borderRadius_stylesSalute_react-native--canary.835.6822826221.ts
color
color_default_ios-swift--canary.835.6822826221.swift
color_default_kotlin--canary.835.6822826221.kt
color_default_react-native--canary.835.6822826221.ts
color_default_xml--canary.835.6822826221.xml
color_plasma_b2c_ios-swift--canary.835.6822826221.swift
color_plasma_b2c_kotlin--canary.835.6822826221.kt
color_plasma_b2c_react-native--canary.835.6822826221.ts
color_plasma_b2c_xml--canary.835.6822826221.xml
color_plasma_web_ios-swift--canary.835.6822826221.swift
color_plasma_web_kotlin--canary.835.6822826221.kt
color_plasma_web_react-native--canary.835.6822826221.ts
color_plasma_web_xml--canary.835.6822826221.xml
color_sberHealth_ios-swift--canary.835.6822826221.swift
color_sberHealth_kotlin--canary.835.6822826221.kt
color_sberHealth_react-native--canary.835.6822826221.ts
color_sberHealth_xml--canary.835.6822826221.xml
color_sbermarket_business_ios-swift--canary.835.6822826221.swift
color_sbermarket_business_kotlin--canary.835.6822826221.kt
color_sbermarket_business_react-native--canary.835.6822826221.ts
color_sbermarket_business_xml--canary.835.6822826221.xml
color_sbermarket_ios-swift--canary.835.6822826221.swift
color_sbermarket_kotlin--canary.835.6822826221.kt
color_sbermarket_metro_ios-swift--canary.835.6822826221.swift
color_sbermarket_metro_kotlin--canary.835.6822826221.kt
color_sbermarket_metro_react-native--canary.835.6822826221.ts
color_sbermarket_metro_xml--canary.835.6822826221.xml
color_sbermarket_react-native--canary.835.6822826221.ts
color_sbermarket_selgros_ios-swift--canary.835.6822826221.swift
color_sbermarket_selgros_kotlin--canary.835.6822826221.kt
color_sbermarket_selgros_react-native--canary.835.6822826221.ts
color_sbermarket_selgros_xml--canary.835.6822826221.xml
color_sbermarket_wlbusiness_ios-swift--canary.835.6822826221.swift
color_sbermarket_wlbusiness_kotlin--canary.835.6822826221.kt
color_sbermarket_wlbusiness_react-native--canary.835.6822826221.ts
color_sbermarket_wlbusiness_xml--canary.835.6822826221.xml
color_sbermarket_xml--canary.835.6822826221.xml
color_sberonline_ios-swift--canary.835.6822826221.swift
color_sberonline_kotlin--canary.835.6822826221.kt
color_sberonline_react-native--canary.835.6822826221.ts
color_sberonline_xml--canary.835.6822826221.xml
color_sberprime_ios-swift--canary.835.6822826221.swift
color_sberprime_kotlin--canary.835.6822826221.kt
color_sberprime_react-native--canary.835.6822826221.ts
color_sberprime_xml--canary.835.6822826221.xml
color_stylesSalute_ios-swift--canary.835.6822826221.swift
color_stylesSalute_kotlin--canary.835.6822826221.kt
color_stylesSalute_react-native--canary.835.6822826221.ts
color_stylesSalute_xml--canary.835.6822826221.xml
shadow
shadow_default_react-native--canary.835.6822826221.ts
shadow_plasma_b2c_react-native--canary.835.6822826221.ts
shadow_plasma_web_react-native--canary.835.6822826221.ts
shadow_sberHealth_react-native--canary.835.6822826221.ts
shadow_sbermarket_business_react-native--canary.835.6822826221.ts
shadow_sbermarket_metro_react-native--canary.835.6822826221.ts
shadow_sbermarket_react-native--canary.835.6822826221.ts
shadow_sbermarket_selgros_react-native--canary.835.6822826221.ts
shadow_sbermarket_wlbusiness_react-native--canary.835.6822826221.ts
shadow_sberonline_react-native--canary.835.6822826221.ts
shadow_sberprime_react-native--canary.835.6822826221.ts
shadow_stylesSalute_react-native--canary.835.6822826221.ts
spacing
spacing_default_react-native--canary.835.6822826221.ts
spacing_plasma_b2c_react-native--canary.835.6822826221.ts
spacing_plasma_web_react-native--canary.835.6822826221.ts
spacing_sberHealth_react-native--canary.835.6822826221.ts
spacing_sbermarket_business_react-native--canary.835.6822826221.ts
spacing_sbermarket_metro_react-native--canary.835.6822826221.ts
spacing_sbermarket_react-native--canary.835.6822826221.ts
spacing_sbermarket_selgros_react-native--canary.835.6822826221.ts
spacing_sbermarket_wlbusiness_react-native--canary.835.6822826221.ts
spacing_sberonline_react-native--canary.835.6822826221.ts
spacing_sberprime_react-native--canary.835.6822826221.ts
spacing_stylesSalute_react-native--canary.835.6822826221.ts
typo
typo_mage_ios-swift--canary.835.6822826221.swift
typo_mage_kotlin--canary.835.6822826221.kt
typo_mage_react-native--canary.835.6822826221.ts
typo_plasma_ios-swift--canary.835.6822826221.swift
typo_plasma_kotlin--canary.835.6822826221.kt
typo_plasma_react-native--canary.835.6822826221.ts
typo_ruler_ios-swift--canary.835.6822826221.swift
typo_ruler_kotlin--canary.835.6822826221.kt
typo_ruler_react-native--canary.835.6822826221.ts
typo_sage_ios-swift--canary.835.6822826221.swift
typo_sage_kotlin--canary.835.6822826221.kt
typo_sage_react-native--canary.835.6822826221.ts
typo_sbermarket_ios-swift--canary.835.6822826221.swift
typo_sbermarket_kotlin--canary.835.6822826221.kt
typo_sbermarket_react-native--canary.835.6822826221.ts
typo_soulmate_ios-swift--canary.835.6822826221.swift
typo_soulmate_kotlin--canary.835.6822826221.kt
typo_soulmate_react-native--canary.835.6822826221.ts
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Version

Published prerelease version: @salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]
@salutejs/[email protected]

Changelog

Release Notes

plasma-ASDK: Add new package "ASDK" (#835)

Plasma-asdk:

  • Поднят storybook
  • Опубликован npm пакет
  • Обновлена/добавлнена Typography (в виде компонентов как старого, так и нового формата)
  • Добавлены компоненты: Button, Checkbox, Link, Radiobox, Spinner

Plasma-new-hope:

Добавлена типографика в виде компонент как старой, так и новой типографики, а так же в виде mixins.


plasma-infra: Add .editorconfig (#837)

Добавлен:

  • .editorconfig
  • package.json в .prettierignore

What/why Changed

Что бы локальные настройки IDE форматирования не применялись для файлов проекта.

Для консистентного форматирования добавлен.editorconfig и для всех package.json сделано форматирование с учетом отступа в 4 пробела.

Так же добавлено правило .prettierignore для package.json, что бы lintstaged не применял для него форматирование.

⚡ Component performance testing

Result: 🟢 OK

plasma-infra(audit): Resolve root dependencies(dev) vulnerabilities (#824)

Почищен корневой package.json:

  1. Удален storybook
  2. Исправлен ряд critical vulnerabilities
  3. Добавлены зависимости, которые раньше доставлялись транзитивно из-за установки storybook.

What/why Changed

Storybook удален так как является рудиментом от установки/использования библиотеки chromatic.

Screenshot 2023-10-11 at 12 42 31

Resolve transitive dev dependencies

  • @babel/plugin-proposal-class-properties
  • @babel/plugin-transform-react-constant-elements
  • babel-loader
  • url-loader

Note: ранее доставлялись транзитивно из-за установки storybook и его плагинов

Для корректного запуска perf test:

  • react - для запуска perf test
  • react-dom - для запуска perf test

feat(plasma-new-hope): Add calendar with new architecture (#821)

Добавлена реализация компонента Calendar в новой архитектуре.

Добавлены сборки компонента для новых тем plasma_web, plasma_b2c, sds_engineer.

Добавлены сборки компонента для старых библиотек @salutejs/plasma-web, @salutejs/plasma-b2c.

Удалён компонент Calendar из @salutejs/plasma-hope.

Поправил небольшой баг (issue) с типизацией для mergeConfig: если у компонента были обязательные пропсы ts ругался, что их не хватает в самом конфиге.

fixes: #597

⚡ Component performance testing

Result: 🟢 OK

⚡ Component performance testing

Result: 🟢 OK

⚡ Component performance testing

Result: 🟢 OK

⚡ Component performance testing

Result: 🟢 OK

⚡ Component performance testing

Result: 🟢 OK


🚀 Enhancement

  • plasma-ASDK: Add new package "ASDK" #835 (@TitanKuzmich)
  • @salutejs/plasma-asdk
  • @salutejs/plasma-tokens, @salutejs/plasma-typo
  • @salutejs/plasma-asdk, @salutejs/plasma-new-hope
  • @salutejs/plasma-icons
  • @salutejs/plasma-new-hope
  • @salutejs/plasma-b2c, @salutejs/plasma-new-hope, @salutejs/plasma-web
  • @salutejs/plasma-hope
  • @salutejs/plasma-b2c, @salutejs/plasma-hope, @salutejs/plasma-web

🐛 Bug Fix

  • chore(website): reformat package.json #837 (@Yakutoc)
  • plasma-infra: Add .editorconfig #837 (@Yakutoc)
  • plasma-infra(audit): Resolve root dependencies(dev) vulnerabilities #824 (@Yakutoc)
  • @salutejs/plasma-cy-utils, @salutejs/plasma-sb-utils, @salutejs/plasma-tokens-utils
  • @salutejs/plasma-b2c, @salutejs/plasma-colors, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-new-hope, @salutejs/cra-template-plasma-shop-template, @salutejs/plasma-temple, @salutejs/plasma-tokens-b2b, @salutejs/plasma-tokens-b2c, @salutejs/plasma-tokens-core, @salutejs/plasma-tokens-web, @salutejs/plasma-tokens, @salutejs/plasma-typo, @salutejs/plasma-ui, @salutejs/plasma-web
  • @salutejs/plasma-temple
    • chore(plasma-temple): add "@storybook/addon-knobs" #824 (@Yakutoc)
  • @salutejs/plasma-ui
    • plasma-infra(audit): Resolve root dependencies(dev) vulnerabilities #824 (@Yakutoc)

⚠️ Pushed to dev

  • @salutejs/plasma-b2c, @salutejs/plasma-colors, @salutejs/plasma-core, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-new-hope, @salutejs/cra-template-plasma-shop-template, @salutejs/plasma-temple, @salutejs/plasma-tokens-b2b, @salutejs/plasma-tokens-b2c, @salutejs/plasma-tokens-core, @salutejs/plasma-tokens-web, @salutejs/plasma-tokens, @salutejs/plasma-typo, @salutejs/plasma-ui, @salutejs/plasma-web, @salutejs/plasma-cy-utils, @salutejs/plasma-sb-utils, @salutejs/plasma-tokens-utils
  • @salutejs/plasma-b2c, @salutejs/plasma-hope, @salutejs/plasma-icons, @salutejs/plasma-temple, @salutejs/plasma-ui, @salutejs/plasma-web
  • @salutejs/plasma-temple, @salutejs/plasma-ui
  • @salutejs/plasma-b2c, @salutejs/plasma-hope, @salutejs/plasma-new-hope, @salutejs/plasma-web

Authors: 4

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-835/

@TitanKuzmich TitanKuzmich force-pushed the plasma-2212/assistant-sdk branch from 4107309 to 1ad9289 Compare November 8, 2023 12:51
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-835/

@TitanKuzmich TitanKuzmich force-pushed the plasma-2212/assistant-sdk branch from 1ad9289 to 249045b Compare November 8, 2023 13:24
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-835/

@TitanKuzmich TitanKuzmich force-pushed the plasma-2212/assistant-sdk branch from 249045b to d447dd3 Compare November 9, 2023 08:00
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-835/

@TitanKuzmich TitanKuzmich force-pushed the plasma-2212/assistant-sdk branch from d447dd3 to 008a52c Compare November 9, 2023 09:02
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-835/

@Yakutoc
Copy link
Collaborator

Yakutoc commented Nov 9, 2023

@TitanKuzmich

  • Проверить локально установку пакета @salutejs/plasma-asdk

Локально завелось:
image
image

@Yakutoc Yakutoc changed the title plasma ASDK plasma-ASDK: Add new package "ASDK" Nov 9, 2023
@TitanKuzmich TitanKuzmich force-pushed the plasma-2212/assistant-sdk branch from 008a52c to 779cdb0 Compare November 9, 2023 12:05
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-835/

@TitanKuzmich TitanKuzmich force-pushed the plasma-2212/assistant-sdk branch from 779cdb0 to 1d75102 Compare November 9, 2023 12:51
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-835/

/*
* Хак, который фиксит применение applySpacing для linaria
*/
useEffect(() => {}, []);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я наверное пропустил, но есть понимание, почему этот хак работает?

@TitanKuzmich TitanKuzmich force-pushed the plasma-2212/assistant-sdk branch from 1d75102 to fe3bb8f Compare November 10, 2023 07:59
@TitanKuzmich TitanKuzmich force-pushed the plasma-2212/assistant-sdk branch from fe3bb8f to b9fb562 Compare November 10, 2023 08:18
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semgrep found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-835/

Copy link
Contributor Author

@TitanKuzmich TitanKuzmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Вернулась проблема со стилями календаря в сторибуке plasma-new-hope. Решим в другом пр

@TitanKuzmich TitanKuzmich force-pushed the plasma-2212/assistant-sdk branch from b9fb562 to 20b6100 Compare November 10, 2023 09:05
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-835/

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Nov 10, 2023
Merged via the queue into dev with commit aa9d59f Nov 10, 2023
24 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2212/assistant-sdk branch November 10, 2023 09:35
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

2 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

2 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plasma-web: Calendar - redesign & refactoring ( PLASMA-2085 )
4 participants