fix(plasma-theme-builder): Fix authorization modal #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neretin-trike
requested review from
Yeti-or,
Yakutoc and
kayman233
as code owners
|
Theme Builder app deployed! |
neretin-trike
force-pushed
the
neretinaa/fix-theme-builder-auth
branch
from
ed96a73 to
9801d85
Compare
|
Theme Builder app deployed! |
neretin-trike
force-pushed
the
neretinaa/fix-theme-builder-auth
branch
from
9801d85 to
ee4ee52
Compare
neretin-trike
changed the title
|
Theme Builder app deployed! |
Yeti-or
reviewed
Oct 27, 2023
| @@ -29,7 +29,7 @@ jobs: | |||
| # TODO: https://github.com/salute-developers/plasma/issues/255 | |||
| - name: Lerna bootstrap with scope | |||
| run: | | |||
| npx lerna bootstrap --scope @salutejs/plasma-theme-builder --scope=@salutejs/plasma-{tokens,tokens-utils,typo} | |||
There was a problem hiding this comment.
там не только typo, другие пакеты тоже (если пробовать их устанавливать). Кажется, что это проблема в cra, на это уже давно issue у нас заведено
Yeti-or
approved these changes
Oct 27, 2023
Yakutoc
approved these changes
Oct 30, 2023
This was referenced Oct 30, 2023
|
🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Обновлены зависимости scope, которые ставятся через lerna bootstrap
What/why Changed
Добавление других зависимостей в scope ломают сборку: #255
🐤 Download canary assets:
Version
Published prerelease version:
@salutejs/[email protected]Changelog
🐛 Bug Fix
Authors: 2