Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plasma-web/b2c): move tokens from dev deps to deps #807

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Oct 11, 2023

Release Notes

@salutejs/plasma-tokens-b2c и @salutejs/plasma-tokens-web установлены как обычные dependencies;
@salutejs/plasma-tokens-b2b требуется в plasma-web, так же была поставлена как обычная зависимость, в plasma-b2c нигде не используется, поэтому было удалено

What/why Changed

Если поставить библиотеку @salutejs/plasma-web или @salutejs/plasma-b2c в проект next, то при импорте любого компонента появляется ошибка об отсутствии токенов;

🐤 Download canary assets:
borderRadius
borderRadius_default_react-native--canary.807.6506039479.ts
borderRadius_plasma_b2c_react-native--canary.807.6506039479.ts
borderRadius_plasma_web_react-native--canary.807.6506039479.ts
borderRadius_sberHealth_react-native--canary.807.6506039479.ts
borderRadius_sbermarket_business_react-native--canary.807.6506039479.ts
borderRadius_sbermarket_metro_react-native--canary.807.6506039479.ts
borderRadius_sbermarket_react-native--canary.807.6506039479.ts
borderRadius_sbermarket_selgros_react-native--canary.807.6506039479.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.807.6506039479.ts
borderRadius_sberonline_react-native--canary.807.6506039479.ts
borderRadius_sberprime_react-native--canary.807.6506039479.ts
borderRadius_stylesSalute_react-native--canary.807.6506039479.ts
color
color_default_ios-swift--canary.807.6506039479.swift
color_default_kotlin--canary.807.6506039479.kt
color_default_react-native--canary.807.6506039479.ts
color_default_xml--canary.807.6506039479.xml
color_plasma_b2c_ios-swift--canary.807.6506039479.swift
color_plasma_b2c_kotlin--canary.807.6506039479.kt
color_plasma_b2c_react-native--canary.807.6506039479.ts
color_plasma_b2c_xml--canary.807.6506039479.xml
color_plasma_web_ios-swift--canary.807.6506039479.swift
color_plasma_web_kotlin--canary.807.6506039479.kt
color_plasma_web_react-native--canary.807.6506039479.ts
color_plasma_web_xml--canary.807.6506039479.xml
color_sberHealth_ios-swift--canary.807.6506039479.swift
color_sberHealth_kotlin--canary.807.6506039479.kt
color_sberHealth_react-native--canary.807.6506039479.ts
color_sberHealth_xml--canary.807.6506039479.xml
color_sbermarket_business_ios-swift--canary.807.6506039479.swift
color_sbermarket_business_kotlin--canary.807.6506039479.kt
color_sbermarket_business_react-native--canary.807.6506039479.ts
color_sbermarket_business_xml--canary.807.6506039479.xml
color_sbermarket_ios-swift--canary.807.6506039479.swift
color_sbermarket_kotlin--canary.807.6506039479.kt
color_sbermarket_metro_ios-swift--canary.807.6506039479.swift
color_sbermarket_metro_kotlin--canary.807.6506039479.kt
color_sbermarket_metro_react-native--canary.807.6506039479.ts
color_sbermarket_metro_xml--canary.807.6506039479.xml
color_sbermarket_react-native--canary.807.6506039479.ts
color_sbermarket_selgros_ios-swift--canary.807.6506039479.swift
color_sbermarket_selgros_kotlin--canary.807.6506039479.kt
color_sbermarket_selgros_react-native--canary.807.6506039479.ts
color_sbermarket_selgros_xml--canary.807.6506039479.xml
color_sbermarket_wlbusiness_ios-swift--canary.807.6506039479.swift
color_sbermarket_wlbusiness_kotlin--canary.807.6506039479.kt
color_sbermarket_wlbusiness_react-native--canary.807.6506039479.ts
color_sbermarket_wlbusiness_xml--canary.807.6506039479.xml
color_sbermarket_xml--canary.807.6506039479.xml
color_sberonline_ios-swift--canary.807.6506039479.swift
color_sberonline_kotlin--canary.807.6506039479.kt
color_sberonline_react-native--canary.807.6506039479.ts
color_sberonline_xml--canary.807.6506039479.xml
color_sberprime_ios-swift--canary.807.6506039479.swift
color_sberprime_kotlin--canary.807.6506039479.kt
color_sberprime_react-native--canary.807.6506039479.ts
color_sberprime_xml--canary.807.6506039479.xml
color_stylesSalute_ios-swift--canary.807.6506039479.swift
color_stylesSalute_kotlin--canary.807.6506039479.kt
color_stylesSalute_react-native--canary.807.6506039479.ts
color_stylesSalute_xml--canary.807.6506039479.xml
shadow
shadow_default_react-native--canary.807.6506039479.ts
shadow_plasma_b2c_react-native--canary.807.6506039479.ts
shadow_plasma_web_react-native--canary.807.6506039479.ts
shadow_sberHealth_react-native--canary.807.6506039479.ts
shadow_sbermarket_business_react-native--canary.807.6506039479.ts
shadow_sbermarket_metro_react-native--canary.807.6506039479.ts
shadow_sbermarket_react-native--canary.807.6506039479.ts
shadow_sbermarket_selgros_react-native--canary.807.6506039479.ts
shadow_sbermarket_wlbusiness_react-native--canary.807.6506039479.ts
shadow_sberonline_react-native--canary.807.6506039479.ts
shadow_sberprime_react-native--canary.807.6506039479.ts
shadow_stylesSalute_react-native--canary.807.6506039479.ts
spacing
spacing_default_react-native--canary.807.6506039479.ts
spacing_plasma_b2c_react-native--canary.807.6506039479.ts
spacing_plasma_web_react-native--canary.807.6506039479.ts
spacing_sberHealth_react-native--canary.807.6506039479.ts
spacing_sbermarket_business_react-native--canary.807.6506039479.ts
spacing_sbermarket_metro_react-native--canary.807.6506039479.ts
spacing_sbermarket_react-native--canary.807.6506039479.ts
spacing_sbermarket_selgros_react-native--canary.807.6506039479.ts
spacing_sbermarket_wlbusiness_react-native--canary.807.6506039479.ts
spacing_sberonline_react-native--canary.807.6506039479.ts
spacing_sberprime_react-native--canary.807.6506039479.ts
spacing_stylesSalute_react-native--canary.807.6506039479.ts
typo
typo_mage_ios-swift--canary.807.6506039479.swift
typo_mage_kotlin--canary.807.6506039479.kt
typo_mage_react-native--canary.807.6506039479.ts
typo_plasma_ios-swift--canary.807.6506039479.swift
typo_plasma_kotlin--canary.807.6506039479.kt
typo_plasma_react-native--canary.807.6506039479.ts
typo_ruler_ios-swift--canary.807.6506039479.swift
typo_ruler_kotlin--canary.807.6506039479.kt
typo_ruler_react-native--canary.807.6506039479.ts
typo_sage_ios-swift--canary.807.6506039479.swift
typo_sage_kotlin--canary.807.6506039479.kt
typo_sage_react-native--canary.807.6506039479.ts
typo_sbermarket_ios-swift--canary.807.6506039479.swift
typo_sbermarket_kotlin--canary.807.6506039479.kt
typo_sbermarket_react-native--canary.807.6506039479.ts
typo_soulmate_ios-swift--canary.807.6506039479.swift
typo_soulmate_kotlin--canary.807.6506039479.kt
typo_soulmate_react-native--canary.807.6506039479.ts
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-807/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

@TitanKuzmich TitanKuzmich force-pushed the plasma-2187/fix-plasma-web-b2c-deps branch from ab6353e to 5156519 Compare October 12, 2023 08:36
@TitanKuzmich TitanKuzmich changed the title chore(plasma-web/b2c): move tokens from dev deps to deps fix(plasma-web/b2c): move tokens from dev deps to deps Oct 12, 2023
@TitanKuzmich TitanKuzmich force-pushed the plasma-2187/fix-plasma-web-b2c-deps branch from 5156519 to fc4438c Compare October 12, 2023 11:06
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-807/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

@TitanKuzmich TitanKuzmich force-pushed the plasma-2187/fix-plasma-web-b2c-deps branch from fc4438c to 074b9d2 Compare October 13, 2023 08:43
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-807/

@Salute-Eva
Copy link
Contributor

@Salute-Eva
Copy link
Contributor

Component performance testing

Result: 🟢 Success

Check out report in job artifacts!

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Oct 13, 2023
Merged via the queue into dev with commit 20978d3 Oct 13, 2023
22 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2187/fix-plasma-web-b2c-deps branch October 13, 2023 09:34
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants