Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma-infra(audit): Delete storybook in root package.json #806

Closed
wants to merge 30 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
11cfc69
chore(plasma-new-hope): add sds_engineer theme
Yeti-or Sep 29, 2023
f1e4abd
chore(plasma-new-hope): remove plasma-old theme
Yeti-or Sep 29, 2023
da23685
feat(plasma-core, plasma-web, plasma-b2c): ModalBase component
kayman233 Sep 26, 2023
9eb47ae
fix(plasma-core): refactor in PopupBase/ModalBase
kayman233 Sep 28, 2023
4764bb0
Update versions
Salute-Eva Sep 29, 2023
e3386c1
chore: update package-locks
Salute-Eva Sep 29, 2023
ea70fb5
fix(plasma-web-docs): Make button blur prop deprecated
TitanKuzmich Oct 2, 2023
134d62c
docs: generate new api for plasma-core
TitanKuzmich Oct 2, 2023
66f0577
docs: fix remove node-modules command
TitanKuzmich Oct 2, 2023
22b8a57
Update versions
Salute-Eva Oct 3, 2023
fcd1a31
chore: update package-locks
Salute-Eva Oct 3, 2023
039e4c6
chore: add pull request template
Yakutoc Oct 2, 2023
7d74ca3
fix(plasma-ui): change sheet-handler color
TitanKuzmich Oct 2, 2023
bda594c
Update versions
Salute-Eva Oct 5, 2023
426af1e
chore: update package-locks
Salute-Eva Oct 5, 2023
f4d923a
ci: Enable "New hope" storybook
Yakutoc Oct 4, 2023
eabb4b2
chore: update package-locks
Salute-Eva Oct 5, 2023
df02356
fix(plasma-new-hope): cjs build
Yeti-or Oct 5, 2023
5f815a6
fix(plasma-new-hope): fix typo
Yakutoc Oct 6, 2023
3ddffb4
fix(plasma-new-hope): fix version
Yakutoc Oct 6, 2023
b393b75
Update versions
Salute-Eva Oct 7, 2023
eb78eda
chore: update package-locks
Salute-Eva Oct 7, 2023
48a75d8
fix: fix typo
Yakutoc Oct 7, 2023
daf4ba0
Update versions
Salute-Eva Oct 9, 2023
d32935f
chore: update package-locks
Salute-Eva Oct 9, 2023
cc0c79a
chore(plasma-ui): add "@storybook/client-logger"
Yakutoc Oct 11, 2023
2e0e7a9
chore(plasma-docs-ui): add "@types/qs"
Yakutoc Oct 11, 2023
a82a47f
chore(plasma-temple): add "@storybook/addon-knobs"
Yakutoc Oct 11, 2023
e586cdc
chore(@auto): delete import "update-deps" plugin
Yakutoc Oct 11, 2023
6f5ec2b
chore(deps): update dev deps
Yakutoc Oct 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/processing-scope.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ module.exports = () => {
const HAS_PLASMA_WEB = packagesList.includes('@salutejs/plasma-web');
const HAS_PLASMA_B2C = packagesList.includes('@salutejs/plasma-b2c');
const HAS_PLASMA_TEMPLE = packagesList.includes('@salutejs/plasma-temple');
const HAS_PLASMA_HOPE = packagesList.includes('@salutejs/plasma-new-hope');

const HAS_DOCUMENTATION_CHANGED = HAS_PLASMA_UI_DOCS || HAS_PLASMA_WEB_DOCS || HAS_PLASMA_TEMPLE_DOCS;

Expand Down Expand Up @@ -72,5 +73,6 @@ module.exports = () => {
HAS_PLASMA_WEB,
HAS_PLASMA_B2C,
HAS_PLASMA_TEMPLE,
HAS_PLASMA_HOPE,
};
};
5 changes: 5 additions & 0 deletions .github/workflows/change-detection.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ on:
HAS_PLASMA_TEMPLE:
description: ""
value: ${{ jobs.run.outputs.HAS_PLASMA_TEMPLE }}
HAS_PLASMA_HOPE:
description: ""
value: ${{ jobs.run.outputs.HAS_PLASMA_HOPE }}
PACKAGES_ENUMERATION:
description: ""
value: ${{ jobs.run.outputs.PACKAGES_ENUMERATION }}
Expand All @@ -59,6 +62,7 @@ jobs:
HAS_PLASMA_B2C: ${{ steps.set-output.outputs.HAS_PLASMA_B2C }}
HAS_PLASMA_WEB: ${{ steps.set-output.outputs.HAS_PLASMA_WEB }}
HAS_PLASMA_UI: ${{ steps.set-output.outputs.HAS_PLASMA_UI }}
HAS_PLASMA_HOPE: ${{ steps.set-output.outputs.HAS_PLASMA_HOPE }}
PACKAGES_ENUMERATION: ${{ steps.set-output.outputs.PACKAGES_ENUMERATION }}

steps:
Expand Down Expand Up @@ -105,5 +109,6 @@ jobs:
echo "HAS_PLASMA_B2C=${{ fromJSON(steps.scope.outputs.result).HAS_PLASMA_B2C }}" >> $GITHUB_OUTPUT
echo "HAS_PLASMA_WEB=${{ fromJSON(steps.scope.outputs.result).HAS_PLASMA_WEB }}" >> $GITHUB_OUTPUT
echo "HAS_PLASMA_UI=${{ fromJSON(steps.scope.outputs.result).HAS_PLASMA_UI }}" >> $GITHUB_OUTPUT
echo "HAS_PLASMA_HOPE=${{ fromJSON(steps.scope.outputs.result).HAS_PLASMA_HOPE }}" >> $GITHUB_OUTPUT
echo "PACKAGES_ENUMERATION=${{ fromJSON(steps.scope.outputs.result).PACKAGES_ENUMERATION }}" >> $GITHUB_OUTPUT

3 changes: 2 additions & 1 deletion .github/workflows/documentation-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@ jobs:
steps:
# [NOTE]: В проекте default branch - dev, что бы правильно собрать
# актуальную версию для branch master, нужно указать ref = 'master'
- uses: actions/checkout@v3
- uses: actions/checkout@v4
# [DOC]: About REF. The branch, tag or SHA to checkout. When checking out the repository that
# triggered a workflow, this defaults to the reference or SHA for that event.
# Otherwise, **uses the default branch**.
# [DOC]: Last commit on default branch
with:
ref: 'master'
show-progress: false

- name: Prepare repository
run: git fetch --unshallow --tags
Expand Down
20 changes: 17 additions & 3 deletions .github/workflows/documentation-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@ jobs:
PR_NAME: pr-${{ github.event.number }}
ICONS_PUBLIC_URL: /icons
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
show-progress: false

- uses: ./.github/actions/prepare-environment
- name: Prepare environment
uses: ./.github/actions/prepare-environment

- name: Computed scope
id: scope
Expand Down Expand Up @@ -144,6 +147,12 @@ jobs:
npm run storybook:build --prefix="./packages/plasma-temple"
cp -R ./packages/plasma-temple/build-sb ./s3_build/${PR_NAME}/temple-storybook

- name: Plasma "New Hope" Storybook
if: ${{ needs.scope.outputs.HAS_PLASMA_HOPE == 'true' }}
run: |
npm run storybook:build --prefix="./packages/plasma-new-hope"
cp -R ./packages/plasma-new-hope/build-sb ./s3_build/${PR_NAME}/new-hope-storybook

- name: Install s3cmd
run: pip3 install s3cmd

Expand All @@ -169,10 +178,11 @@ jobs:
HAS_PLASMA_WEB: ${{ fromJSON(needs.scope.outputs.HAS_PLASMA_WEB) }}
HAS_PLASMA_UI: ${{ fromJSON(needs.scope.outputs.HAS_PLASMA_UI) }}
HAS_PLASMA_TEMPLE: ${{ fromJSON(needs.scope.outputs.HAS_PLASMA_TEMPLE) }}
HAS_PLASMA_HOPE: ${{ fromJSON(needs.scope.outputs.HAS_PLASMA_HOPE) }}
with:
github-token: ${{secrets.GH_TOKEN}}
script: |
const { HAS_PLASMA_B2C, HAS_PLASMA_WEB, HAS_PLASMA_UI, HAS_PLASMA_TEMPLE } = process.env;
const { HAS_PLASMA_B2C, HAS_PLASMA_WEB, HAS_PLASMA_UI, HAS_PLASMA_TEMPLE, HAS_PLASMA_HOPE } = process.env;

const {
issue: { number },
Expand All @@ -199,6 +209,10 @@ jobs:
links.push(`temple storybook: http://plasma.sberdevices.ru/pr/pr-${number}/temple-storybook/`)
}

if (HAS_PLASMA_HOPE === 'true') {
links.push(`new-hope storybook: http://plasma.sberdevices.ru/pr/pr-${number}/new-hope-storybook/`)
}

github.rest.issues.createComment({
issue_number: number,
owner,
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ npx lerna bootstrap --scope [имя пакета 1] --scope [имя пакета
Если возникла какая-либо проблема со сборкой, можно попробовать полностью удалить все зависимости и установить их заново:

```sh
rm -rm ./node_modules/
rm -rf ./node_modules/
npm ci
npx lerna clean -y
npx lerna bootstrap
Expand Down
1 change: 0 additions & 1 deletion auto-plugins/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
import './update-deps';
import './upload-assets-extend';
Loading
Loading