Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plasma-web-docs): Remove button blur prop from component & docs #785

Merged
merged 3 commits into from
Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ npx lerna bootstrap --scope [имя пакета 1] --scope [имя пакета
Если возникла какая-либо проблема со сборкой, можно попробовать полностью удалить все зависимости и установить их заново:

```sh
rm -rm ./node_modules/
rm -rf ./node_modules/
TitanKuzmich marked this conversation as resolved.
Show resolved Hide resolved
npm ci
npx lerna clean -y
npx lerna bootstrap
Expand Down
4 changes: 3 additions & 1 deletion packages/plasma-core/api/plasma-core.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,9 @@ export const buttonFocused = "var(--plasma-colors-button-focused)";
export const buttonPrimary = "var(--plasma-colors-button-primary)";

// @public
export interface ButtonProps<T = HTMLElement> extends Partial<PinProps>, FocusProps, OutlinedProps, DisabledProps, ShiftProps, BlurProps, AsProps, Omit<React.AnchorHTMLAttributes<T>, 'type'>, React.ButtonHTMLAttributes<T> {
export interface ButtonProps<T = HTMLElement> extends Partial<PinProps>, FocusProps, OutlinedProps, DisabledProps, ShiftProps, AsProps, Omit<React.AnchorHTMLAttributes<T>, 'type'>, React.ButtonHTMLAttributes<T> {
Yakutoc marked this conversation as resolved.
Show resolved Hide resolved
// @deprecated
blur?: keyof typeof blurs;
square?: boolean;
stretch?: boolean;
}
Expand Down
12 changes: 8 additions & 4 deletions packages/plasma-core/src/components/Button/Button.types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { FlattenSimpleInterpolation, CSSObject } from 'styled-components';

import type { DisabledProps, FocusProps, OutlinedProps, BlurProps } from '../../mixins';
import type { DisabledProps, FocusProps, OutlinedProps, blurs } from '../../mixins';
import type { ShiftProps, AsProps } from '../../types';
import type { PinProps } from '../../utils';

Expand All @@ -16,7 +16,6 @@ export interface ButtonProps<T = HTMLElement>
OutlinedProps,
DisabledProps,
ShiftProps,
BlurProps,
AsProps,
Omit<React.AnchorHTMLAttributes<T>, 'type'>,
React.ButtonHTMLAttributes<T> {
Expand All @@ -28,6 +27,12 @@ export interface ButtonProps<T = HTMLElement>
* Растягиваемость кнопки (кнопка занимает ширину контейнера)
*/
stretch?: boolean;

/**
* Степень размытия фона
* @deprecated для кнопок без прозрачности не работает
*/
blur?: keyof typeof blurs;
TitanKuzmich marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down Expand Up @@ -141,9 +146,8 @@ export interface StyledButtonProps
OutlinedProps,
DisabledProps,
ShiftProps,
BlurProps,
ButtonIsContentProps,
Pick<ButtonProps, 'square' | 'stretch'> {}
Pick<ButtonProps, 'square' | 'stretch' | 'blur'> {}
TitanKuzmich marked this conversation as resolved.
Show resolved Hide resolved

/**
* @private
Expand Down
Loading