Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plasma-new-hope): add sds_engineer theme #782

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

Yeti-or
Copy link
Contributor

@Yeti-or Yeti-or commented Sep 29, 2023

🐤 Download canary assets:
borderRadius
borderRadius_default_react-native--canary.782.6350563855.ts
borderRadius_plasma_b2c_react-native--canary.782.6350563855.ts
borderRadius_plasma_web_react-native--canary.782.6350563855.ts
borderRadius_sberHealth_react-native--canary.782.6350563855.ts
borderRadius_sbermarket_business_react-native--canary.782.6350563855.ts
borderRadius_sbermarket_metro_react-native--canary.782.6350563855.ts
borderRadius_sbermarket_react-native--canary.782.6350563855.ts
borderRadius_sbermarket_selgros_react-native--canary.782.6350563855.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.782.6350563855.ts
borderRadius_sberonline_react-native--canary.782.6350563855.ts
borderRadius_sberprime_react-native--canary.782.6350563855.ts
borderRadius_stylesSalute_react-native--canary.782.6350563855.ts
color
color_default_ios-swift--canary.782.6350563855.swift
color_default_kotlin--canary.782.6350563855.kt
color_default_react-native--canary.782.6350563855.ts
color_default_xml--canary.782.6350563855.xml
color_plasma_b2c_ios-swift--canary.782.6350563855.swift
color_plasma_b2c_kotlin--canary.782.6350563855.kt
color_plasma_b2c_react-native--canary.782.6350563855.ts
color_plasma_b2c_xml--canary.782.6350563855.xml
color_plasma_web_ios-swift--canary.782.6350563855.swift
color_plasma_web_kotlin--canary.782.6350563855.kt
color_plasma_web_react-native--canary.782.6350563855.ts
color_plasma_web_xml--canary.782.6350563855.xml
color_sberHealth_ios-swift--canary.782.6350563855.swift
color_sberHealth_kotlin--canary.782.6350563855.kt
color_sberHealth_react-native--canary.782.6350563855.ts
color_sberHealth_xml--canary.782.6350563855.xml
color_sbermarket_business_ios-swift--canary.782.6350563855.swift
color_sbermarket_business_kotlin--canary.782.6350563855.kt
color_sbermarket_business_react-native--canary.782.6350563855.ts
color_sbermarket_business_xml--canary.782.6350563855.xml
color_sbermarket_ios-swift--canary.782.6350563855.swift
color_sbermarket_kotlin--canary.782.6350563855.kt
color_sbermarket_metro_ios-swift--canary.782.6350563855.swift
color_sbermarket_metro_kotlin--canary.782.6350563855.kt
color_sbermarket_metro_react-native--canary.782.6350563855.ts
color_sbermarket_metro_xml--canary.782.6350563855.xml
color_sbermarket_react-native--canary.782.6350563855.ts
color_sbermarket_selgros_ios-swift--canary.782.6350563855.swift
color_sbermarket_selgros_kotlin--canary.782.6350563855.kt
color_sbermarket_selgros_react-native--canary.782.6350563855.ts
color_sbermarket_selgros_xml--canary.782.6350563855.xml
color_sbermarket_wlbusiness_ios-swift--canary.782.6350563855.swift
color_sbermarket_wlbusiness_kotlin--canary.782.6350563855.kt
color_sbermarket_wlbusiness_react-native--canary.782.6350563855.ts
color_sbermarket_wlbusiness_xml--canary.782.6350563855.xml
color_sbermarket_xml--canary.782.6350563855.xml
color_sberonline_ios-swift--canary.782.6350563855.swift
color_sberonline_kotlin--canary.782.6350563855.kt
color_sberonline_react-native--canary.782.6350563855.ts
color_sberonline_xml--canary.782.6350563855.xml
color_sberprime_ios-swift--canary.782.6350563855.swift
color_sberprime_kotlin--canary.782.6350563855.kt
color_sberprime_react-native--canary.782.6350563855.ts
color_sberprime_xml--canary.782.6350563855.xml
color_stylesSalute_ios-swift--canary.782.6350563855.swift
color_stylesSalute_kotlin--canary.782.6350563855.kt
color_stylesSalute_react-native--canary.782.6350563855.ts
color_stylesSalute_xml--canary.782.6350563855.xml
shadow
shadow_default_react-native--canary.782.6350563855.ts
shadow_plasma_b2c_react-native--canary.782.6350563855.ts
shadow_plasma_web_react-native--canary.782.6350563855.ts
shadow_sberHealth_react-native--canary.782.6350563855.ts
shadow_sbermarket_business_react-native--canary.782.6350563855.ts
shadow_sbermarket_metro_react-native--canary.782.6350563855.ts
shadow_sbermarket_react-native--canary.782.6350563855.ts
shadow_sbermarket_selgros_react-native--canary.782.6350563855.ts
shadow_sbermarket_wlbusiness_react-native--canary.782.6350563855.ts
shadow_sberonline_react-native--canary.782.6350563855.ts
shadow_sberprime_react-native--canary.782.6350563855.ts
shadow_stylesSalute_react-native--canary.782.6350563855.ts
spacing
spacing_default_react-native--canary.782.6350563855.ts
spacing_plasma_b2c_react-native--canary.782.6350563855.ts
spacing_plasma_web_react-native--canary.782.6350563855.ts
spacing_sberHealth_react-native--canary.782.6350563855.ts
spacing_sbermarket_business_react-native--canary.782.6350563855.ts
spacing_sbermarket_metro_react-native--canary.782.6350563855.ts
spacing_sbermarket_react-native--canary.782.6350563855.ts
spacing_sbermarket_selgros_react-native--canary.782.6350563855.ts
spacing_sbermarket_wlbusiness_react-native--canary.782.6350563855.ts
spacing_sberonline_react-native--canary.782.6350563855.ts
spacing_sberprime_react-native--canary.782.6350563855.ts
spacing_stylesSalute_react-native--canary.782.6350563855.ts
typo
typo_mage_ios-swift--canary.782.6350563855.swift
typo_mage_kotlin--canary.782.6350563855.kt
typo_mage_react-native--canary.782.6350563855.ts
typo_plasma_ios-swift--canary.782.6350563855.swift
typo_plasma_kotlin--canary.782.6350563855.kt
typo_plasma_react-native--canary.782.6350563855.ts
typo_ruler_ios-swift--canary.782.6350563855.swift
typo_ruler_kotlin--canary.782.6350563855.kt
typo_ruler_react-native--canary.782.6350563855.ts
typo_sage_ios-swift--canary.782.6350563855.swift
typo_sage_kotlin--canary.782.6350563855.kt
typo_sage_react-native--canary.782.6350563855.ts
typo_sbermarket_ios-swift--canary.782.6350563855.swift
typo_sbermarket_kotlin--canary.782.6350563855.kt
typo_sbermarket_react-native--canary.782.6350563855.ts
typo_soulmate_ios-swift--canary.782.6350563855.swift
typo_soulmate_kotlin--canary.782.6350563855.kt
typo_soulmate_react-native--canary.782.6350563855.ts
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

const allChildren = getChildren(value);

if (!allChildren.length) {
return { checked: values[value], indeterminate: false };

Check warning

Code scanning / Semgrep

Semgrep Finding: gitlab.eslint.detect-object-injection Warning

Bracket object notation with user input is present, this might allow an attacker to access all properties of the object and even it's prototype, leading to possible code execution.
return { checked: values[value], indeterminate: false };
}

const checkedChildren = allChildren.filter((child) => values[child.value]);

Check warning

Code scanning / Semgrep

Semgrep Finding: gitlab.eslint.detect-object-injection Warning

Bracket object notation with user input is present, this might allow an attacker to access all properties of the object and even it's prototype, leading to possible code execution.
value={item.value}
label={item.label}
disabled={item.disabled}
checked={value[item.value]}

Check warning

Code scanning / Semgrep

Semgrep Finding: gitlab.eslint.detect-object-injection Warning

Bracket object notation with user input is present, this might allow an attacker to access all properties of the object and even it's prototype, leading to possible code execution.
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-782/

@Salute-Eva
Copy link
Contributor

Copy link
Contributor Author

@Yeti-or Yeti-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А давайте это вольем

@Yeti-or Yeti-or marked this pull request as ready for review September 29, 2023 10:12
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-782/

@Salute-Eva
Copy link
Contributor

@Yeti-or Yeti-or added this pull request to the merge queue Sep 29, 2023
Merged via the queue into dev with commit f1e4abd Sep 29, 2023
21 of 22 checks passed
@Yeti-or Yeti-or deleted the yeti-or.sds-eng-theme branch September 29, 2023 11:27
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants