plasm-infra: Split lint and unit tests to different jobs #631

Yakutoc · 2023-07-27T08:59:39Z

Release Notes

Разделили первичные и важные проверки, такие как Lint и Unit tests, в рамках одного workflow на две разные jobs

What Changed

Для атомарности.

Unit tests запускается с помощью lerna run test и поэтому мы можем использовать флаг --since и для lerna bootstrap, и для самой команды запуска тестов.

А вот Lint запускается для всей монорепы, и так получается что флаг --since уже мешает и вносит проблемы, в виде неустановленных пакетов.

Поэтому для этой проверки оставили полный bootstrap.

Check list

plasma-core
plasma-web
plasma-tokens-utils

Ни в одном сценарии не было ошибки связной с неустановленным/отсутствующим пакетом.

https://github.com/salute-developers/plasma/actions/workflows/tests.yml?query=branch%3Aci_refactoring_tests-workflow

🐤 Download canary assets:

color

color_plasma_b2c_ios-swift--canary.631.5690535609.swift
color_plasma_b2c_kotlin--canary.631.5690535609.kt
color_plasma_b2c_react-native--canary.631.5690535609.ts
color_plasma_b2c_xml--canary.631.5690535609.xml
color_sberHealth_ios-swift--canary.631.5690535609.swift
color_sberHealth_kotlin--canary.631.5690535609.kt
color_sberHealth_react-native--canary.631.5690535609.ts
color_sberHealth_xml--canary.631.5690535609.xml
color_sbermarket_business_ios-swift--canary.631.5690535609.swift
color_sbermarket_business_kotlin--canary.631.5690535609.kt
color_sbermarket_business_react-native--canary.631.5690535609.ts
color_sbermarket_business_xml--canary.631.5690535609.xml
color_sbermarket_ios-swift--canary.631.5690535609.swift
color_sbermarket_kotlin--canary.631.5690535609.kt
color_sbermarket_metro_ios-swift--canary.631.5690535609.swift
color_sbermarket_metro_kotlin--canary.631.5690535609.kt
color_sbermarket_metro_react-native--canary.631.5690535609.ts
color_sbermarket_metro_xml--canary.631.5690535609.xml
color_sbermarket_react-native--canary.631.5690535609.ts
color_sbermarket_selgros_ios-swift--canary.631.5690535609.swift
color_sbermarket_selgros_kotlin--canary.631.5690535609.kt
color_sbermarket_selgros_react-native--canary.631.5690535609.ts
color_sbermarket_selgros_xml--canary.631.5690535609.xml
color_sbermarket_wlbusiness_ios-swift--canary.631.5690535609.swift
color_sbermarket_wlbusiness_kotlin--canary.631.5690535609.kt
color_sbermarket_wlbusiness_react-native--canary.631.5690535609.ts
color_sbermarket_wlbusiness_xml--canary.631.5690535609.xml
color_sbermarket_xml--canary.631.5690535609.xml
color_sberonline_ios-swift--canary.631.5690535609.swift
color_sberonline_kotlin--canary.631.5690535609.kt
color_sberonline_react-native--canary.631.5690535609.ts
color_sberonline_xml--canary.631.5690535609.xml
color_sberprime_ios-swift--canary.631.5690535609.swift
color_sberprime_kotlin--canary.631.5690535609.kt
color_sberprime_react-native--canary.631.5690535609.ts
color_sberprime_xml--canary.631.5690535609.xml
color_stylesSalute_ios-swift--canary.631.5690535609.swift
color_stylesSalute_kotlin--canary.631.5690535609.kt
color_stylesSalute_react-native--canary.631.5690535609.ts
color_stylesSalute_xml--canary.631.5690535609.xml

shadow

shadow_plasma_b2c_react-native--canary.631.5690535609.ts
shadow_sberHealth_react-native--canary.631.5690535609.ts
shadow_sbermarket_business_react-native--canary.631.5690535609.ts
shadow_sbermarket_metro_react-native--canary.631.5690535609.ts
shadow_sbermarket_react-native--canary.631.5690535609.ts
shadow_sbermarket_selgros_react-native--canary.631.5690535609.ts
shadow_sbermarket_wlbusiness_react-native--canary.631.5690535609.ts
shadow_sberonline_react-native--canary.631.5690535609.ts
shadow_sberprime_react-native--canary.631.5690535609.ts
shadow_stylesSalute_react-native--canary.631.5690535609.ts

typo

typo_mage_ios-swift--canary.631.5690535609.swift
typo_mage_kotlin--canary.631.5690535609.kt
typo_mage_react-native--canary.631.5690535609.ts
typo_plasma_ios-swift--canary.631.5690535609.swift
typo_plasma_kotlin--canary.631.5690535609.kt
typo_plasma_react-native--canary.631.5690535609.ts
typo_ruler_ios-swift--canary.631.5690535609.swift
typo_ruler_kotlin--canary.631.5690535609.kt
typo_ruler_react-native--canary.631.5690535609.ts
typo_sage_ios-swift--canary.631.5690535609.swift
typo_sage_kotlin--canary.631.5690535609.kt
typo_sage_react-native--canary.631.5690535609.ts
typo_sbermarket_ios-swift--canary.631.5690535609.swift
typo_sbermarket_kotlin--canary.631.5690535609.kt
typo_sbermarket_react-native--canary.631.5690535609.ts
typo_soulmate_ios-swift--canary.631.5690535609.swift
typo_soulmate_kotlin--canary.631.5690535609.kt
typo_soulmate_react-native--canary.631.5690535609.ts

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Salute-Eva · 2023-07-27T09:02:02Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

Salute-Eva · 2023-07-27T09:41:33Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

Salute-Eva · 2023-07-27T09:54:19Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-631/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-631/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-631/web-storybook/

Salute-Eva · 2023-07-27T10:57:24Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

Salute-Eva · 2023-07-27T11:05:10Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-631/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-631/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-631/web-storybook/

Salute-Eva · 2023-07-27T11:18:27Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

Salute-Eva · 2023-07-27T11:37:49Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-631/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-631/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-631/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-631/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-631/temple-storybook/

Salute-Eva · 2023-07-28T07:20:52Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

Salute-Eva · 2023-07-28T07:27:04Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-631/
web storybook: http://plasma.sberdevices.ru/pr/pr-631/web-storybook/

Salute-Eva · 2023-07-28T07:46:10Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

Salute-Eva · 2023-07-28T08:04:42Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-631/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-631/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-631/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-631/ui-storybook/
temple storybook: http://plasma.sberdevices.ru/pr/pr-631/temple-storybook/

Salute-Eva · 2023-07-28T08:12:24Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

.github/workflows/required-primary-checks.yml

Salute-Eva · 2023-07-28T09:13:38Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

Salute-Eva · 2023-07-28T09:22:21Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

Salute-Eva · 2023-07-28T09:42:03Z

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-631/

Salute-Eva · 2023-07-28T09:51:21Z

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-631/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-631/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-631/web-storybook/

Yeti-or · 2023-08-01T09:21:41Z

.github/workflows/required-primary-checks.yml


      - uses: ./.github/actions/prepare-environment

      - name: Lerna bootstrap
-        run: npx lerna bootstrap --ignore @salutejs/plasma-tokens*
+        run: npx lerna bootstrap


я же правильно помню что потом мы разделим линтер по пакетам и втащим --since ?

@Yeti-or Да все правильно, у нас есть задача на это.

Salute-Eva · 2023-08-03T13:49:05Z

Salute-Eva · 2023-08-03T13:49:17Z

Yakutoc added the plasma-infra label Jul 27, 2023

Yakutoc self-assigned this Jul 27, 2023

Yakutoc force-pushed the ci_refactoring_tests-workflow branch from cc14986 to 961441a Compare July 27, 2023 11:16

Yakutoc force-pushed the ci_refactoring_tests-workflow branch from 961441a to a1d667f Compare July 28, 2023 07:18

Yakutoc force-pushed the ci_refactoring_tests-workflow branch from a1d667f to 561802b Compare July 28, 2023 07:43

Yakutoc force-pushed the ci_refactoring_tests-workflow branch from 561802b to 782618c Compare July 28, 2023 08:09

Yakutoc changed the title ~~[WIP] plasm-infra: Split lint and unit tests to different jobs~~ plasm-infra: Split lint and unit tests to different jobs Jul 28, 2023

Yakutoc marked this pull request as ready for review July 28, 2023 08:17

Yakutoc requested review from Yeti-or, neretin-trike and kayman233 as code owners July 28, 2023 08:17

neretin-trike reviewed Jul 28, 2023

View reviewed changes

.github/workflows/required-primary-checks.yml Outdated Show resolved Hide resolved

Yakutoc force-pushed the ci_refactoring_tests-workflow branch from 782618c to b9bb89c Compare July 28, 2023 09:11

neretin-trike approved these changes Jul 28, 2023

View reviewed changes

ci: split lint and unit tests to different jobs

2655bd5

Yakutoc force-pushed the ci_refactoring_tests-workflow branch from b9bb89c to 3bc2402 Compare July 28, 2023 09:20

ci: test

b5fd8ae

Yakutoc force-pushed the ci_refactoring_tests-workflow branch from 3bc2402 to b5fd8ae Compare July 28, 2023 09:40

kayman233 approved these changes Aug 1, 2023

View reviewed changes

Yeti-or approved these changes Aug 1, 2023

View reviewed changes

Yakutoc added this pull request to the merge queue Aug 1, 2023

Merged via the queue into dev with commit 1345e18 Aug 1, 2023

Yakutoc deleted the ci_refactoring_tests-workflow branch August 1, 2023 10:29

Salute-Eva added the released label Aug 3, 2023

Salute-Eva mentioned this pull request Jan 18, 2024

Release by 18.01.2024 #972

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plasm-infra: Split lint and unit tests to different jobs #631

plasm-infra: Split lint and unit tests to different jobs #631

Yakutoc commented Jul 27, 2023 •

edited by Salute-Eva

Loading

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Yeti-or Aug 1, 2023

Yakutoc Aug 1, 2023

Salute-Eva commented Aug 3, 2023

Salute-Eva commented Aug 3, 2023

plasm-infra: Split lint and unit tests to different jobs #631

plasm-infra: Split lint and unit tests to different jobs #631

Conversation

Yakutoc commented Jul 27, 2023 • edited by Salute-Eva Loading

Release Notes

What Changed

Check list

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 27, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Salute-Eva commented Jul 28, 2023

Yeti-or Aug 1, 2023

Choose a reason for hiding this comment

Yakutoc Aug 1, 2023

Choose a reason for hiding this comment

Salute-Eva commented Aug 3, 2023

Salute-Eva commented Aug 3, 2023

Yakutoc commented Jul 27, 2023 •

edited by Salute-Eva

Loading