Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plasma-tokens-native): Update react-native generator for shadow tokens and update schemes #624

Merged

Conversation

neretin-trike
Copy link
Collaborator

@neretin-trike neretin-trike commented Jul 19, 2023

Обновлён генератор токенов теней для фреймворка React-Native для платформ Android и iOS.

Перенесены все токены из .ts файлов в json схемы.

Добавлены токены теней в темы plasma_b2c и sbermarket*

Добавлены пакеты plasma-tokens-native и plasma-tokens-utils в набор скоупов для cypress-common workflow

🐤 Download canary assets:
color
color_asdk_ios-swift--canary.624.5679473797.swift
color_asdk_kotlin--canary.624.5679473797.kt
color_asdk_react-native--canary.624.5679473797.ts
color_asdk_xml--canary.624.5679473797.xml
color_plasma_b2c_ios-swift--canary.624.5679473797.swift
color_plasma_b2c_kotlin--canary.624.5679473797.kt
color_plasma_b2c_react-native--canary.624.5679473797.ts
color_plasma_b2c_xml--canary.624.5679473797.xml
color_sberHealth_ios-swift--canary.624.5679473797.swift
color_sberHealth_kotlin--canary.624.5679473797.kt
color_sberHealth_react-native--canary.624.5679473797.ts
color_sberHealth_xml--canary.624.5679473797.xml
color_sbermarket_business_ios-swift--canary.624.5679473797.swift
color_sbermarket_business_kotlin--canary.624.5679473797.kt
color_sbermarket_business_react-native--canary.624.5679473797.ts
color_sbermarket_business_xml--canary.624.5679473797.xml
color_sbermarket_ios-swift--canary.624.5679473797.swift
color_sbermarket_kotlin--canary.624.5679473797.kt
color_sbermarket_metro_ios-swift--canary.624.5679473797.swift
color_sbermarket_metro_kotlin--canary.624.5679473797.kt
color_sbermarket_metro_react-native--canary.624.5679473797.ts
color_sbermarket_metro_xml--canary.624.5679473797.xml
color_sbermarket_react-native--canary.624.5679473797.ts
color_sbermarket_selgros_ios-swift--canary.624.5679473797.swift
color_sbermarket_selgros_kotlin--canary.624.5679473797.kt
color_sbermarket_selgros_react-native--canary.624.5679473797.ts
color_sbermarket_selgros_xml--canary.624.5679473797.xml
color_sbermarket_wlbusiness_ios-swift--canary.624.5679473797.swift
color_sbermarket_wlbusiness_kotlin--canary.624.5679473797.kt
color_sbermarket_wlbusiness_react-native--canary.624.5679473797.ts
color_sbermarket_wlbusiness_xml--canary.624.5679473797.xml
color_sbermarket_xml--canary.624.5679473797.xml
color_sberonline_ios-swift--canary.624.5679473797.swift
color_sberonline_kotlin--canary.624.5679473797.kt
color_sberonline_react-native--canary.624.5679473797.ts
color_sberonline_xml--canary.624.5679473797.xml
color_sberprime_ios-swift--canary.624.5679473797.swift
color_sberprime_kotlin--canary.624.5679473797.kt
color_sberprime_react-native--canary.624.5679473797.ts
color_sberprime_xml--canary.624.5679473797.xml
shadow
shadow_asdk_react-native--canary.624.5679473797.ts
shadow_plasma_b2c_react-native--canary.624.5679473797.ts
shadow_sberHealth_react-native--canary.624.5679473797.ts
shadow_sbermarket_business_react-native--canary.624.5679473797.ts
shadow_sbermarket_metro_react-native--canary.624.5679473797.ts
shadow_sbermarket_react-native--canary.624.5679473797.ts
shadow_sbermarket_selgros_react-native--canary.624.5679473797.ts
shadow_sbermarket_wlbusiness_react-native--canary.624.5679473797.ts
shadow_sberonline_react-native--canary.624.5679473797.ts
shadow_sberprime_react-native--canary.624.5679473797.ts
typo
typo_mage_ios-swift--canary.624.5679473797.swift
typo_mage_kotlin--canary.624.5679473797.kt
typo_mage_react-native--canary.624.5679473797.ts
typo_plasma_ios-swift--canary.624.5679473797.swift
typo_plasma_kotlin--canary.624.5679473797.kt
typo_plasma_react-native--canary.624.5679473797.ts
typo_ruler_ios-swift--canary.624.5679473797.swift
typo_ruler_kotlin--canary.624.5679473797.kt
typo_ruler_react-native--canary.624.5679473797.ts
typo_sage_ios-swift--canary.624.5679473797.swift
typo_sage_kotlin--canary.624.5679473797.kt
typo_sage_react-native--canary.624.5679473797.ts
typo_sbermarket_ios-swift--canary.624.5679473797.swift
typo_sbermarket_kotlin--canary.624.5679473797.kt
typo_sbermarket_react-native--canary.624.5679473797.ts
typo_soulmate_ios-swift--canary.624.5679473797.swift
typo_soulmate_kotlin--canary.624.5679473797.kt
typo_soulmate_react-native--canary.624.5679473797.ts
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-624/

@Salute-Eva
Copy link
Contributor

@Yeti-or
Copy link
Contributor

Yeti-or commented Jul 25, 2023

А почему всё упало?

@neretin-trike
Copy link
Collaborator Author

А почему всё упало?

есть ощущение, что это снова из-за того, что у нас есть изменения в dev в пакетах (без бампа версий, и соответственно релиза), которые используются здесь, но нет в npm

@neretin-trike neretin-trike force-pushed the neretinaa/update-react-native-shadow-tokens-generator branch from e33b3b9 to acfe74f Compare July 27, 2023 10:20
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-624/

@neretin-trike neretin-trike force-pushed the neretinaa/update-react-native-shadow-tokens-generator branch from acfe74f to 3db88c0 Compare July 27, 2023 10:32
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-624/

@Salute-Eva
Copy link
Contributor

@neretin-trike neretin-trike added this pull request to the merge queue Jul 27, 2023
Merged via the queue into dev with commit d439f2a Jul 27, 2023
@neretin-trike neretin-trike deleted the neretinaa/update-react-native-shadow-tokens-generator branch July 27, 2023 11:37
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

3 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants