Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLASMA-4192: Improve project infra #1666

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Dec 19, 2024

Core

Breadcrumbs, Calendar, Combobox, Dropdown, Select, Slider

  • исправлены циклические зависимости

SDDS-CS

Chore

  • добавлен объект exports в package.json для исправления ошибки vitest (vitest issue)

SDDS-SERV

Chore

  • fix error in path of d.ts file generation in copy-linaria.sh script;
  • add exports object in package json for vitest (vitest issue)

What/why changed

By default components are exported built with linaria. So they use plain css. In order to fix build, there is need to use two more rollup plugins:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1666/

@TitanKuzmich TitanKuzmich self-assigned this Dec 19, 2024
@TitanKuzmich TitanKuzmich force-pushed the plasma-fix-type-generation branch from 163cbb1 to 2b76a69 Compare December 19, 2024 12:29
@Yakutoc Yakutoc changed the title plasma-fix-type-generation: fix typings path infra(sdds-serv): fix typings path Dec 19, 2024
@Yakutoc Yakutoc added the changelog-skip Exclude pull request changes from changelog label Dec 19, 2024
@TitanKuzmich TitanKuzmich force-pushed the plasma-fix-type-generation branch from 2b76a69 to 695283c Compare December 20, 2024 09:25
@TitanKuzmich TitanKuzmich force-pushed the plasma-fix-type-generation branch from 695283c to 487e78a Compare December 20, 2024 11:48
@TitanKuzmich TitanKuzmich force-pushed the plasma-fix-type-generation branch from e0b226d to 965e64c Compare December 20, 2024 16:06
@TitanKuzmich TitanKuzmich force-pushed the plasma-fix-type-generation branch from 965e64c to 6ad8287 Compare December 22, 2024 10:40
@TitanKuzmich TitanKuzmich added this pull request to the merge queue Dec 23, 2024
Merged via the queue into dev with commit 5c5d7d6 Dec 23, 2024
31 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-fix-type-generation branch December 23, 2024 12:52
@TitanKuzmich
Copy link
Contributor Author

Проблемы, с которыми столкнулся во время поиска решения:

  • билд происходит в рутовую директорию, а не в отдельную папку (нужно внимательно следить за всеми исключениями (например в tsconfig), чтобы случайно не переписать исходники)
  • нужно упростить секцию scripts в package.json, так как есть некоторые дублирующиеся команды, а есть команды, которые просто переиспользуют какую-то одну другую команду
  • проблема копипаста пакетов: в styled-components и emotion зачастую неправильные пути до файла с типами

@Yakutoc Yakutoc changed the title infra(sdds-serv): fix typings path PLASMA-4192: Improve project infra Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants