Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4116: изменен уровень передачи rest в Popup #1636

Merged
merged 2 commits into from
Dec 11, 2024
Merged

PLASMA-4116: изменен уровень передачи rest в Popup #1636

merged 2 commits into from
Dec 11, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Dec 10, 2024 •
edited by Salute-Eva
Loading

Core

Popup, Drawer

  • rest аргументы прокидываются на уровень .popup-base-root элемента

What/why changed

Нужно пробрасывать data-аттрибуты на уровень ниже в Popup

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1636/

@TitanKuzmich TitanKuzmich changed the title Plasma-4116: изменен уровень передачи rest в Popup PLASMA-4116: изменен уровень передачи rest в Popup Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1636/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1636/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1636/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1636/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1636/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1636/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1636/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1636/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1636/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1636/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1636/ui-storybook/

@TitanKuzmich TitanKuzmich marked this pull request as ready for review December 10, 2024 11:45
@github-actions github-actions bot requested review from denivladislav and iljs and removed request for Yeti-or, Yakutoc, neretin-trike and shuga2704 December 10, 2024 11:45
@TitanKuzmich TitanKuzmich added this pull request to the merge queue Dec 11, 2024
@Yakutoc Yakutoc removed the request for review from denivladislav December 11, 2024 08:46
Merged via the queue into dev with commit f1475f2 Dec 11, 2024
29 checks passed
@TitanKuzmich TitanKuzmich deleted the PLASMA-4116 branch December 11, 2024 08:52
@Salute-Eva Salute-Eva mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuga2704 shuga2704 shuga2704 approved these changes

@iljs iljs iljs approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

Assignees

@TitanKuzmich TitanKuzmich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanKuzmich @Yakutoc @iljs @shuga2704