Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4114: fix renderValue prop in Select #1634

Merged
merged 1 commit into from
Dec 9, 2024
Merged

PLASMA-4114: fix renderValue prop in Select #1634

merged 1 commit into from
Dec 9, 2024

Conversation

shuga2704
Copy link
Contributor

@shuga2704 shuga2704 commented Dec 9, 2024 •
edited by Salute-Eva
Loading

Core

Select

  • исправлен баг, связанный с неправильной работой свойства renderValue в одиночном режиме варианта textfield-like;

What/why changed

Исправлен баг, связанный с неправильной работой свойства renderValue в одиночном режиме варианта textfield-like. Добавлены тесты.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@shuga2704 shuga2704 self-assigned this Dec 9, 2024
@shuga2704 shuga2704 marked this pull request as ready for review December 9, 2024 13:17
@github-actions github-actions bot requested review from iljs and TitanKuzmich and removed request for Yeti-or, Yakutoc, neretin-trike and TitanKuzmich December 9, 2024 13:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1634/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1634/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1634/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1634/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1634/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1634/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1634/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1634/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1634/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1634/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1634/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1634/ui-storybook/

@shuga2704 shuga2704 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into dev with commit c589255 Dec 9, 2024
29 checks passed
@shuga2704 shuga2704 deleted the plasma-4114 branch December 9, 2024 18:34
@Salute-Eva Salute-Eva mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@iljs iljs iljs approved these changes

Assignees

@shuga2704 shuga2704

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuga2704 @iljs @TitanKuzmich @Yakutoc