Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-3619: add 'hover' trigger to Tooltip #1625

Merged
merged 1 commit into from
Dec 11, 2024
Merged

PLASMA-3619: add 'hover' trigger to Tooltip #1625

merged 1 commit into from
Dec 11, 2024

Conversation

vadim-kudr
Copy link
Contributor

@vadim-kudr vadim-kudr commented Dec 6, 2024 •
edited by Salute-Eva
Loading

Core

Tooltip, Popover

  • добавлена возможность открывать по hover

What/why changed

Добавлено внутреннее состояния для тултипа: isOpen
Прокинуты свойства в Popover: trigger, closeOnEsc, closeOnOverlayClick. Так же, невидимый блок между target и контентом

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@vadim-kudr vadim-kudr self-assigned this Dec 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1625/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1625/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1625/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1625/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1625/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1625/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1625/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1625/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1625/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1625/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1625/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1625/ui-storybook/

@vadim-kudr vadim-kudr requested a review from Irinkv December 9, 2024 13:25
@vadim-kudr vadim-kudr changed the title feat: add 'hover' trigger to Tooltip PLASMA-3619: add 'hover' trigger to Tooltip Dec 10, 2024
@vadim-kudr vadim-kudr marked this pull request as ready for review December 10, 2024 08:15
@TitanKuzmich
Copy link
Contributor

Думаю, нужна еще дока по новому функционалу и тесты в b2c

@TitanKuzmich
Copy link
Contributor

Заполни описание по шаблону, пожалуйста

@vadim-kudr
Copy link
Contributor Author

Думаю, нужна еще дока по новому функционалу и тесты в b2c

доку добавлю, тесты там по ссылке с web

@vadim-kudr vadim-kudr added this pull request to the merge queue Dec 11, 2024
Merged via the queue into dev with commit cc5a2e8 Dec 11, 2024
30 checks passed
@vadim-kudr vadim-kudr deleted the PLASMA-3619 branch December 11, 2024 06:59
@Salute-Eva Salute-Eva mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irinkv Irinkv Irinkv approved these changes

@denivladislav denivladislav denivladislav approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

Assignees

@vadim-kudr vadim-kudr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadim-kudr @TitanKuzmich @denivladislav @Irinkv