Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4068: add pointerVisibility & currentValueVisibility props to Slider & fixes #1616

Merged
merged 1 commit into from
Dec 10, 2024
Merged

PLASMA-4068: add pointerVisibility & currentValueVisibility props to Slider & fixes #1616

merged 1 commit into from
Dec 10, 2024

Conversation

vadim-kudr
Copy link
Contributor

@vadim-kudr vadim-kudr commented Dec 4, 2024 •
edited by Salute-Eva
Loading

Core

Slider

  • исправлено поведение работы value (внешнее управление)
  • исправлена подстветка шкалы в вертикальном и инверсированном режиме
  • добавлены новые свойства pointerVisibility, currentValueVisibility

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1616/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1616/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1616/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1616/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1616/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1616/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1616/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1616/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1616/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1616/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1616/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1616/ui-storybook/

@vadim-kudr vadim-kudr self-assigned this Dec 5, 2024
@vadim-kudr vadim-kudr added bugs Something isn't working plasma-components labels Dec 10, 2024
@vadim-kudr vadim-kudr changed the title fix: add hoverVisibility prop to Slider & fixes fix: add pointerVisibility & currentValueVisibility props to Slider & fixes Dec 10, 2024
@vadim-kudr vadim-kudr marked this pull request as ready for review December 10, 2024 04:08
@github-actions github-actions bot requested a review from iljs December 10, 2024 04:09
@vadim-kudr vadim-kudr changed the title fix: add pointerVisibility & currentValueVisibility props to Slider & fixes PLASMA-4068: add pointerVisibility & currentValueVisibility props to Slider & fixes Dec 10, 2024
@vadim-kudr vadim-kudr requested a review from luizasok December 10, 2024 08:21
@Yakutoc Yakutoc removed bugs Something isn't working plasma-components labels Dec 10, 2024
denivladislav
denivladislav reviewed Dec 10, 2024
View reviewed changes
packages/plasma-new-hope/src/components/Slider/components/Single/Single.types.ts
* always - всегда отображать
* hover - при наведении на Slider
*/
currentValueVisibility: 'always' | 'hover';
Copy link
Contributor

@denivladislav denivladislav Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Раньше у нас был только проп showCurrentValue, включение и выключение которого регулировало наличие / отсутствие текущего значения.

Теперь, чтобы показывать значение, нам нужны сразу два пропа (надо showCurrentValue выставить в true, а ещё выставить нужное значение для currentValueVisibility)

Предлагаю оставить только один, currentValueVisibility со значениями 'always' | 'hover' | 'none'.

Что думаешь?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно и один указывать, showCurrentValue. он точно останется для обратной совместимости. просто я значения по умолчанию не прописал, для currentValueVisibility = 'always'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, showCurrentValue должен остаться для обратной совместимости. Но как будто в дальнейшем достаточно только currentValueVisibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

звучит логично, да

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для обратной совместимости оставили showCurrentValue и currentValueVisibility с вариантами always/hover

@vadim-kudr vadim-kudr added this pull request to the merge queue Dec 10, 2024
Merged via the queue into dev with commit 1b22c41 Dec 10, 2024
29 checks passed
@vadim-kudr vadim-kudr deleted the PLASMA-4068 branch December 10, 2024 22:25
@Salute-Eva Salute-Eva mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denivladislav denivladislav denivladislav approved these changes

@luizasok luizasok luizasok approved these changes

@iljs iljs iljs approved these changes

Assignees

@vadim-kudr vadim-kudr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vadim-kudr @iljs @luizasok @denivladislav @Yakutoc