Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-3991: add beforeList and afterList props in Select #1613

Merged
merged 1 commit into from
Dec 4, 2024
Merged

PLASMA-3991: add beforeList and afterList props in Select #1613

merged 1 commit into from
Dec 4, 2024

Conversation

shuga2704
Copy link
Contributor

@shuga2704 shuga2704 commented Dec 3, 2024 •
edited by Yakutoc
Loading

Core

Select

  • добавлены свойства beforeList и afterList, которые служат ячейками для content в выпадающем списке;

What/why changed

добавлены свойства beforeList и afterList, которые служат ячейками для контента в выпадающем списке;

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@shuga2704 shuga2704 self-assigned this Dec 3, 2024
@shuga2704 shuga2704 marked this pull request as ready for review December 3, 2024 15:33
@github-actions github-actions bot requested review from denivladislav and vadim-kudr and removed request for Yeti-or, Yakutoc, neretin-trike and TitanKuzmich December 3, 2024 15:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1613/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1613/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1613/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1613/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1613/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1613/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1613/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1613/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1613/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1613/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1613/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1613/ui-storybook/

vadim-kudr
vadim-kudr reviewed Dec 4, 2024
View reviewed changes
packages/plasma-b2c/src/components/Select/Select.component-test.tsx
cy.matchImageSnapshot();
});

it('prop: afterList', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

еще бы тест на оба свойства сразу

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пока что мы свойства тестируем отдельно, без комбинаций

vadim-kudr
vadim-kudr reviewed Dec 4, 2024
View reviewed changes
packages/plasma-new-hope/src/components/Select/Select.types.ts
/**
* Ячейка для контента в конце выпадающего списка.
*/
afterList?: React.ReactNode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не вижу api.md файлов

denivladislav
denivladislav reviewed Dec 4, 2024
View reviewed changes
packages/plasma-new-hope/src/components/Select/Select.types.ts
Comment on lines +148 to +152
beforeList?: React.ReactNode;
/**
* Ячейка для контента в конце выпадающего списка.
*/
afterList?: React.ReactNode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мб добавить для них пример в доку?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это лишнее, примеры в доке для более комплексных кейсов

@shuga2704 shuga2704 enabled auto-merge December 4, 2024 18:46
@shuga2704 shuga2704 added this pull request to the merge queue Dec 4, 2024
Merged via the queue into dev with commit 960c4d7 Dec 4, 2024
29 checks passed
@shuga2704 shuga2704 deleted the plasma-3991 branch December 4, 2024 19:21
This was referenced Dec 9, 2024
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denivladislav denivladislav denivladislav approved these changes

@vadim-kudr vadim-kudr vadim-kudr approved these changes

Assignees

@shuga2704 shuga2704

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuga2704 @vadim-kudr @denivladislav @Yakutoc