Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4007: TextField input width with textAfter #1611

Merged
merged 1 commit into from
Dec 21, 2024
Merged

PLASMA-4007: TextField input width with textAfter #1611

merged 1 commit into from
Dec 21, 2024

Conversation

vadim-kudr
Copy link
Contributor

@vadim-kudr vadim-kudr commented Dec 3, 2024 •
edited by Salute-Eva
Loading

Core

TextField

  • исправлено поведение свойства textAfter, теперь позиция всегда рядом с текстом input

What/why changed

input в TextField при textAfter теперь имеет динамическую ширину

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1611/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1611/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1611/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1611/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1611/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1611/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1611/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1611/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1611/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1611/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1611/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1611/ui-storybook/

@vadim-kudr vadim-kudr self-assigned this Dec 5, 2024
@vadim-kudr vadim-kudr changed the title fix: TextField input width with textAfter PLASMA-4007: TextField input width with textAfter Dec 10, 2024
@vadim-kudr vadim-kudr marked this pull request as ready for review December 10, 2024 12:07
@vadim-kudr vadim-kudr added the bugs Something isn't working label Dec 10, 2024
@github-actions github-actions bot requested review from iljs and TitanKuzmich and removed request for Yeti-or, Yakutoc, neretin-trike, TitanKuzmich and shuga2704 December 10, 2024 12:14
TitanKuzmich
TitanKuzmich reviewed Dec 10, 2024
View reviewed changes
packages/plasma-new-hope/src/components/TextField/TextField.styles.ts Outdated
min-width: ${({ hasDynamicWidth }) => (hasDynamicWidth ? 'auto' : '60%')};

${Input} {
field-sizing: ${({ hasDynamicWidth }) => (hasDynamicWidth ? 'content' : 'auto')};
Copy link
Contributor

@TitanKuzmich TitanKuzmich Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Смущает на caniuse это свойство. Чет там много браузеров красные
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это да, можно в тест отдать, пусть посмотряот

вариант, с export const defaultCharacterWidth = '1ch'; не подходит, для него monospace шрифт нужен

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

печально, все. Игорь посмотрел. 3й вариант остался )

@Yakutoc Yakutoc removed the bugs Something isn't working label Dec 11, 2024
@vadim-kudr vadim-kudr added the bugs Something isn't working label Dec 20, 2024
@vadim-kudr vadim-kudr requested a review from Irinkv December 20, 2024 10:07
@vadim-kudr vadim-kudr added this pull request to the merge queue Dec 21, 2024
Merged via the queue into dev with commit 4c753d5 Dec 21, 2024
32 checks passed
@vadim-kudr vadim-kudr deleted the PLASMA-4007 branch December 21, 2024 07:45
@Salute-Eva Salute-Eva mentioned this pull request Dec 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irinkv Irinkv Irinkv approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@iljs iljs iljs approved these changes

Assignees

@vadim-kudr vadim-kudr

Labels
bugs Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vadim-kudr @iljs @TitanKuzmich @Irinkv @Yakutoc