Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-3415: объединение padding-токенов #1600

Merged
merged 3 commits into from
Dec 4, 2024
Merged

PLASMA-3415: объединение padding-токенов #1600

merged 3 commits into from
Dec 4, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Nov 28, 2024 •
edited by Yakutoc
Loading

Core

Chip, ChipGroup, Counter, Combobox, Select, TextField, TextArea, TextFieldGrop

  • изменен формат записи токена для padding с длинной на короткую

What/why changed

Из-за оптимизации css для сборки, "длинная запись" (4 padding) схлопывается в "короткую" (1 padding). Туда мог попасть undefined и поломать padding.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Nov 28, 2024
@TitanKuzmich TitanKuzmich marked this pull request as ready for review November 28, 2024 10:24
@github-actions github-actions bot requested review from iljs and vadim-kudr and removed request for Yeti-or, Yakutoc, neretin-trike and shuga2704 November 28, 2024 10:35
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1600/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1600/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1600/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1600/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1600/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1600/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1600/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1600/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1600/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1600/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1600/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1600/ui-storybook/

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Dec 4, 2024
Merged via the queue into dev with commit 906d3d2 Dec 4, 2024
29 checks passed
@TitanKuzmich TitanKuzmich deleted the PLASMA-3415 branch December 4, 2024 10:16
@Yakutoc Yakutoc removed the misc label Dec 5, 2024
This was referenced Dec 9, 2024
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iljs iljs iljs approved these changes

@vadim-kudr vadim-kudr vadim-kudr approved these changes

Assignees

@TitanKuzmich TitanKuzmich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanKuzmich @vadim-kudr @iljs @Yakutoc