Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4067: Popup hydration issues [FIX] #1596

Merged
merged 1 commit into from
Dec 3, 2024
Merged

PLASMA-4067: Popup hydration issues [FIX] #1596

merged 1 commit into from
Dec 3, 2024

Conversation

shuga2704
Copy link
Contributor

@shuga2704 shuga2704 commented Nov 27, 2024 •
edited by Yakutoc
Loading

Core

Popup

  • добавлено свойство UNSAFE_SSR_ENABLED в PopupProvider для корректной hydration компонента;

What/why changed

Пока решили рефакторинг попапов отложить, ограничились вводом нового временного свойства UNSAFE_SSR_ENABLED для тех, кто использует попапы в нексте. Также создано ишью: 1599

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@shuga2704 shuga2704 self-assigned this Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1596/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1596/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1596/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1596/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1596/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1596/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1596/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1596/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1596/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1596/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1596/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1596/ui-storybook/

@shuga2704 shuga2704 marked this pull request as ready for review November 28, 2024 11:35
@github-actions github-actions bot requested review from neretin-trike and TitanKuzmich and removed request for Yeti-or, Yakutoc, neretin-trike and TitanKuzmich November 28, 2024 11:36
@shuga2704 shuga2704 changed the title feat(plasma-*, sdds-*): fix Popup hydration issues PLASMA-4067: fix Popup hydration issues Nov 29, 2024
@Yakutoc Yakutoc changed the title PLASMA-4067: fix Popup hydration issues PLASMA-4067: Popup hydration issues [FIX] Dec 3, 2024
@shuga2704 shuga2704 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into dev with commit addbc8d Dec 3, 2024
29 checks passed
@shuga2704 shuga2704 deleted the plasma-4067 branch December 3, 2024 10:51
This was referenced Dec 9, 2024
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neretin-trike neretin-trike neretin-trike approved these changes

@Yakutoc Yakutoc Yakutoc left review comments

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

Assignees

@shuga2704 shuga2704

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuga2704 @Yakutoc @neretin-trike @TitanKuzmich