Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "RequiredProps" unions in TextField & TextArea #1593

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

vadim-kudr
Copy link
Contributor

@vadim-kudr vadim-kudr commented Nov 26, 2024

TextField, TextArea

  • исправлен баг в типах, связанный с пропсом required

What/why changed

Убраны потенциальные баги упирающиеся в возможности работы union в typescript, поправлены тесты c required

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@vadim-kudr vadim-kudr added the bugs Something isn't working label Nov 26, 2024
@vadim-kudr vadim-kudr self-assigned this Nov 26, 2024
@vadim-kudr vadim-kudr marked this pull request as ready for review November 26, 2024 15:15
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1593/

@neretin-trike
Copy link
Collaborator

добавьте плс все ссылки в прку, которые находил Дима, когда обсуждали эту проблему

@vadim-kudr vadim-kudr added this pull request to the merge queue Nov 26, 2024
Merged via the queue into dev with commit abb4a10 Nov 26, 2024
34 checks passed
@vadim-kudr vadim-kudr deleted the PLASMA-4022 branch November 26, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants