Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-new-hope, sdds-cs: fix Switch design #1569

Merged
merged 2 commits into from
Nov 22, 2024
Merged

plasma-new-hope, sdds-cs: fix Switch design #1569

merged 2 commits into from
Nov 22, 2024

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Nov 19, 2024 •
edited by Salute-Eva
Loading

Switch

  • исправлены токены для Switch в core-компоненте с целью добавления возможности реализации нового дизайна
  • исправлены токены для Switch в пакете sdds-cs
  • убран control для свойства size в storybook пакета sdds-cs

What/why changed

Before:

switch_before.mov

After:

switch_after.mov
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1569/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1569/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1569/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1569/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1569/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1569/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1569/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1569/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1569/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1569/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1569/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1569/ui-storybook/

@denivladislav denivladislav force-pushed the PLASMA-3842/switch-sdds-cs branch from 9c80a52 to 9f9e1fc Compare November 19, 2024 07:18
@denivladislav denivladislav force-pushed the PLASMA-3842/switch-sdds-cs branch from 9f9e1fc to 0c01035 Compare November 20, 2024 09:51
@denivladislav denivladislav self-assigned this Nov 20, 2024
@denivladislav denivladislav marked this pull request as ready for review November 21, 2024 07:47
@github-actions github-actions bot requested review from iljs and vadim-kudr and removed request for Yeti-or, Yakutoc, neretin-trike, TitanKuzmich and shuga2704 November 21, 2024 07:47
@denivladislav denivladislav force-pushed the PLASMA-3842/switch-sdds-cs branch from 0c01035 to 92d8c57 Compare November 22, 2024 13:19
@denivladislav denivladislav added this pull request to the merge queue Nov 22, 2024
Merged via the queue into dev with commit ce7e83c Nov 22, 2024
29 checks passed
@denivladislav denivladislav deleted the PLASMA-3842/switch-sdds-cs branch November 22, 2024 13:56
@Salute-Eva Salute-Eva mentioned this pull request Nov 27, 2024
Merged
This was referenced Nov 29, 2024
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 9, 2024
Closed
Merged
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simashova simashova simashova approved these changes

@iljs iljs iljs approved these changes

@vadim-kudr vadim-kudr vadim-kudr approved these changes

Assignees

@denivladislav denivladislav

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@denivladislav @vadim-kudr @iljs @simashova @Yakutoc