Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-*, sdds-*): Add required functionality in Select #1561

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat(plasma-*, sdds-*): Add required functionality in Select #1561

merged 1 commit into from
Nov 20, 2024

Conversation

shuga2704
Copy link
Contributor

@shuga2704 shuga2704 commented Nov 14, 2024 •
edited by Salute-Eva
Loading

Select

  • добавлены св-ва required, requiredPlacement и optional;
    plasma-b2c Select -- prop required, requiredPlacement snap

What/why changed

Т.к. св-ва required, requiredPlacement и optional есть в оригинальном TextField, было принято решение перенести их и в Select.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@shuga2704 shuga2704 self-assigned this Nov 14, 2024
@shuga2704 shuga2704 changed the title feat(plasma-*, sdds-*): Add required functionality feat(plasma-*, sdds-*): Add required functionality in Select Nov 14, 2024
@shuga2704 shuga2704 marked this pull request as ready for review November 14, 2024 15:00
@github-actions github-actions bot requested review from vadim-kudr and Yakutoc and removed request for Yeti-or, Yakutoc, neretin-trike and TitanKuzmich November 14, 2024 15:00
@Yakutoc
Copy link
Collaborator

Yakutoc commented Nov 14, 2024

@shuga2704 Добавь скриншот стало, чтобы визуально было понятно. Я про блок с резюме

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1561/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1561/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1561/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1561/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1561/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1561/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1561/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1561/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1561/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1561/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1561/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1561/ui-storybook/

@Yakutoc
Copy link
Collaborator

Yakutoc commented Nov 15, 2024

@shuga2704 А кто из дизайна будет ревью делать?

@shuga2704 shuga2704 requested a review from Irinkv November 19, 2024 08:44
@shuga2704 shuga2704 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into dev with commit 76622bd Nov 20, 2024
30 checks passed
@shuga2704 shuga2704 deleted the plasma-3931 branch November 20, 2024 12:40
@Salute-Eva Salute-Eva mentioned this pull request Nov 27, 2024
Merged
This was referenced Nov 29, 2024
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 9, 2024
Closed
Merged
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irinkv Irinkv Irinkv approved these changes

@vadim-kudr vadim-kudr vadim-kudr approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

Assignees

@shuga2704 shuga2704

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuga2704 @Yakutoc @vadim-kudr @Irinkv