feat(plasma-themes): Add fallback tokens for `plasma-themes` #1355

neretin-trike · 2024-08-13T16:28:52Z

Tokens

Добавлены методы генерации старых токенов в библиотеку core-themes
Добавлены токены со старым неймингом (префиксом plasma-colors) в вертикаль plasma-themes для тем plasma-web и plasma-b2c

What/why changed

Сейчас, если использовать способ подключения тем через библиотеку @salutejs/plasma-themes часть компонент будет не корректно отображаться, т.к. в них используются старые токены.

🐤 Download canary assets:

borderRadius

borderRadius_caldera_online_react-native--canary.1355.10409432870.ts
borderRadius_default_react-native--canary.1355.10409432870.ts
borderRadius_flamingo_react-native--canary.1355.10409432870.ts
borderRadius_plasma_b2c_react-native--canary.1355.10409432870.ts
borderRadius_plasma_web_react-native--canary.1355.10409432870.ts
borderRadius_sberHealth_react-native--canary.1355.10409432870.ts
borderRadius_sbermarket_business_react-native--canary.1355.10409432870.ts
borderRadius_sbermarket_metro_react-native--canary.1355.10409432870.ts
borderRadius_sbermarket_react-native--canary.1355.10409432870.ts
borderRadius_sbermarket_selgros_react-native--canary.1355.10409432870.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.1355.10409432870.ts
borderRadius_sberonline_react-native--canary.1355.10409432870.ts
borderRadius_sberprime_react-native--canary.1355.10409432870.ts
borderRadius_sdds_cs_react-native--canary.1355.10409432870.ts
borderRadius_sdds_dfa_react-native--canary.1355.10409432870.ts
borderRadius_sdds_serv_react-native--canary.1355.10409432870.ts
borderRadius_stylesSalute_react-native--canary.1355.10409432870.ts

shadow

shadow_caldera_online_react-native--canary.1355.10409432870.ts
shadow_default_react-native--canary.1355.10409432870.ts
shadow_flamingo_react-native--canary.1355.10409432870.ts
shadow_plasma_b2c_react-native--canary.1355.10409432870.ts
shadow_plasma_web_react-native--canary.1355.10409432870.ts
shadow_sberHealth_react-native--canary.1355.10409432870.ts
shadow_sbermarket_business_react-native--canary.1355.10409432870.ts
shadow_sbermarket_metro_react-native--canary.1355.10409432870.ts
shadow_sbermarket_react-native--canary.1355.10409432870.ts
shadow_sbermarket_selgros_react-native--canary.1355.10409432870.ts
shadow_sbermarket_wlbusiness_react-native--canary.1355.10409432870.ts
shadow_sberonline_react-native--canary.1355.10409432870.ts
shadow_sberprime_react-native--canary.1355.10409432870.ts
shadow_sdds_cs_react-native--canary.1355.10409432870.ts
shadow_sdds_dfa_react-native--canary.1355.10409432870.ts
shadow_sdds_serv_react-native--canary.1355.10409432870.ts
shadow_stylesSalute_react-native--canary.1355.10409432870.ts

color

color_caldera_online_ios-swift--canary.1355.10409432870.swift
color_caldera_online_kotlin--canary.1355.10409432870.kt
color_caldera_online_react-native--canary.1355.10409432870.ts
color_caldera_online_xml--canary.1355.10409432870.xml
color_default_ios-swift--canary.1355.10409432870.swift
color_default_kotlin--canary.1355.10409432870.kt
color_default_react-native--canary.1355.10409432870.ts
color_default_xml--canary.1355.10409432870.xml
color_flamingo_ios-swift--canary.1355.10409432870.swift
color_flamingo_kotlin--canary.1355.10409432870.kt
color_flamingo_react-native--canary.1355.10409432870.ts
color_flamingo_xml--canary.1355.10409432870.xml
color_plasma_b2c_ios-swift--canary.1355.10409432870.swift
color_plasma_b2c_kotlin--canary.1355.10409432870.kt
color_plasma_b2c_react-native--canary.1355.10409432870.ts
color_plasma_b2c_xml--canary.1355.10409432870.xml
color_plasma_web_ios-swift--canary.1355.10409432870.swift
color_plasma_web_kotlin--canary.1355.10409432870.kt
color_plasma_web_react-native--canary.1355.10409432870.ts
color_plasma_web_xml--canary.1355.10409432870.xml
color_sberHealth_ios-swift--canary.1355.10409432870.swift
color_sberHealth_kotlin--canary.1355.10409432870.kt
color_sberHealth_react-native--canary.1355.10409432870.ts
color_sberHealth_xml--canary.1355.10409432870.xml
color_sbermarket_business_ios-swift--canary.1355.10409432870.swift
color_sbermarket_business_kotlin--canary.1355.10409432870.kt
color_sbermarket_business_react-native--canary.1355.10409432870.ts
color_sbermarket_business_xml--canary.1355.10409432870.xml
color_sbermarket_ios-swift--canary.1355.10409432870.swift
color_sbermarket_kotlin--canary.1355.10409432870.kt
color_sbermarket_metro_ios-swift--canary.1355.10409432870.swift
color_sbermarket_metro_kotlin--canary.1355.10409432870.kt
color_sbermarket_metro_react-native--canary.1355.10409432870.ts
color_sbermarket_metro_xml--canary.1355.10409432870.xml
color_sbermarket_react-native--canary.1355.10409432870.ts
color_sbermarket_selgros_ios-swift--canary.1355.10409432870.swift
color_sbermarket_selgros_kotlin--canary.1355.10409432870.kt
color_sbermarket_selgros_react-native--canary.1355.10409432870.ts
color_sbermarket_selgros_xml--canary.1355.10409432870.xml
color_sbermarket_wlbusiness_ios-swift--canary.1355.10409432870.swift
color_sbermarket_wlbusiness_kotlin--canary.1355.10409432870.kt
color_sbermarket_wlbusiness_react-native--canary.1355.10409432870.ts
color_sbermarket_wlbusiness_xml--canary.1355.10409432870.xml
color_sbermarket_xml--canary.1355.10409432870.xml
color_sberonline_ios-swift--canary.1355.10409432870.swift
color_sberonline_kotlin--canary.1355.10409432870.kt
color_sberonline_react-native--canary.1355.10409432870.ts
color_sberonline_xml--canary.1355.10409432870.xml
color_sberprime_ios-swift--canary.1355.10409432870.swift
color_sberprime_kotlin--canary.1355.10409432870.kt
color_sberprime_react-native--canary.1355.10409432870.ts
color_sberprime_xml--canary.1355.10409432870.xml
color_sdds_cs_ios-swift--canary.1355.10409432870.swift
color_sdds_cs_kotlin--canary.1355.10409432870.kt
color_sdds_cs_react-native--canary.1355.10409432870.ts
color_sdds_cs_xml--canary.1355.10409432870.xml
color_sdds_dfa_ios-swift--canary.1355.10409432870.swift
color_sdds_dfa_kotlin--canary.1355.10409432870.kt
color_sdds_dfa_react-native--canary.1355.10409432870.ts
color_sdds_dfa_xml--canary.1355.10409432870.xml
color_sdds_serv_ios-swift--canary.1355.10409432870.swift
color_sdds_serv_kotlin--canary.1355.10409432870.kt
color_sdds_serv_react-native--canary.1355.10409432870.ts
color_sdds_serv_xml--canary.1355.10409432870.xml
color_stylesSalute_ios-swift--canary.1355.10409432870.swift
color_stylesSalute_kotlin--canary.1355.10409432870.kt
color_stylesSalute_react-native--canary.1355.10409432870.ts
color_stylesSalute_xml--canary.1355.10409432870.xml

spacing

spacing_caldera_online_react-native--canary.1355.10409432870.ts
spacing_default_react-native--canary.1355.10409432870.ts
spacing_flamingo_react-native--canary.1355.10409432870.ts
spacing_plasma_b2c_react-native--canary.1355.10409432870.ts
spacing_plasma_web_react-native--canary.1355.10409432870.ts
spacing_sberHealth_react-native--canary.1355.10409432870.ts
spacing_sbermarket_business_react-native--canary.1355.10409432870.ts
spacing_sbermarket_metro_react-native--canary.1355.10409432870.ts
spacing_sbermarket_react-native--canary.1355.10409432870.ts
spacing_sbermarket_selgros_react-native--canary.1355.10409432870.ts
spacing_sbermarket_wlbusiness_react-native--canary.1355.10409432870.ts
spacing_sberonline_react-native--canary.1355.10409432870.ts
spacing_sberprime_react-native--canary.1355.10409432870.ts
spacing_sdds_cs_react-native--canary.1355.10409432870.ts
spacing_sdds_dfa_react-native--canary.1355.10409432870.ts
spacing_sdds_serv_react-native--canary.1355.10409432870.ts
spacing_stylesSalute_react-native--canary.1355.10409432870.ts

typo

typo_mage_ios-swift--canary.1355.10409432870.swift
typo_mage_kotlin--canary.1355.10409432870.kt
typo_mage_react-native--canary.1355.10409432870.ts
typo_plasma_ios-swift--canary.1355.10409432870.swift
typo_plasma_kotlin--canary.1355.10409432870.kt
typo_plasma_react-native--canary.1355.10409432870.ts
typo_ruler_ios-swift--canary.1355.10409432870.swift
typo_ruler_kotlin--canary.1355.10409432870.kt
typo_ruler_react-native--canary.1355.10409432870.ts
typo_sage_ios-swift--canary.1355.10409432870.swift
typo_sage_kotlin--canary.1355.10409432870.kt
typo_sage_react-native--canary.1355.10409432870.ts
typo_sbermarket_ios-swift--canary.1355.10409432870.swift
typo_sbermarket_kotlin--canary.1355.10409432870.kt
typo_sbermarket_react-native--canary.1355.10409432870.ts
typo_soulmate_ios-swift--canary.1355.10409432870.swift
typo_soulmate_kotlin--canary.1355.10409432870.kt
typo_soulmate_react-native--canary.1355.10409432870.ts

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

github-actions · 2024-08-13T16:32:38Z

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1355/

github-actions · 2024-08-13T16:46:41Z

Documentation preview deployed!

github-actions · 2024-08-13T16:50:17Z

⚡ Component performance testing

Result: 🟢 OK

packages/themes/core-themes/src/utils/fallbackTokens.ts

github-actions · 2024-08-15T19:53:11Z

⚡ Component performance testing

Result: 🟢 OK

github-actions · 2024-08-16T07:28:55Z

⚡ Component performance testing

Result: 🟢 OK

…ckage.json

github-actions · 2024-08-16T08:46:53Z

⚡ Component performance testing

Result: 🟢 OK

neretin-trike requested review from Yeti-or, Yakutoc, TitanKuzmich and shuga2704 as code owners August 13, 2024 16:28

neretin-trike temporarily deployed to internal August 13, 2024 16:28 — with GitHub Actions Inactive

neretin-trike changed the title ~~feat(plasma-b2c): Add fallback tokens plasma themes~~ feat(plasma-themes): Add fallback tokens plasma themes Aug 13, 2024

neretin-trike self-assigned this Aug 13, 2024

neretin-trike added the plasma-tokens label Aug 13, 2024

neretin-trike changed the title ~~feat(plasma-themes): Add fallback tokens plasma themes~~ feat(plasma-themes): Add fallback tokens for plasma-themes Aug 13, 2024

denivladislav reviewed Aug 15, 2024

View reviewed changes

packages/themes/core-themes/src/utils/fallbackTokens.ts Show resolved Hide resolved

denivladislav self-requested a review August 15, 2024 08:16

denivladislav approved these changes Aug 15, 2024

View reviewed changes

neretin-trike force-pushed the neretinaa/add-fallback-tokens-plasma-themes branch from ab2c6cd to 5ba68f4 Compare August 15, 2024 19:32

neretin-trike temporarily deployed to internal August 15, 2024 19:32 — with GitHub Actions Inactive

Yakutoc removed request for Yeti-or and TitanKuzmich August 16, 2024 05:37

neretin-trike force-pushed the neretinaa/add-fallback-tokens-plasma-themes branch from 5ba68f4 to 3934224 Compare August 16, 2024 07:08

neretin-trike temporarily deployed to internal August 16, 2024 07:08 — with GitHub Actions Inactive

neretin-trike added 3 commits August 16, 2024 13:26

feat(plasma-web,plasma-b2c): Add @salutejs/plasma-themes deps to pa…

c7ed8f4

…ckage.json

feat(core-themes): Add methods for fallback tokens generate

550fe68

feat(plasma-themes): Update theme

e2fe71c

neretin-trike force-pushed the neretinaa/add-fallback-tokens-plasma-themes branch from 3934224 to e2fe71c Compare August 16, 2024 08:26

neretin-trike temporarily deployed to internal August 16, 2024 08:26 — with GitHub Actions Inactive

neretin-trike requested review from iljs and removed request for Yakutoc and shuga2704 August 16, 2024 10:48

iljs approved these changes Aug 16, 2024

View reviewed changes

neretin-trike added this pull request to the merge queue Aug 16, 2024

Merged via the queue into dev with commit 6ade372 Aug 16, 2024
32 checks passed

neretin-trike deleted the neretinaa/add-fallback-tokens-plasma-themes branch August 16, 2024 11:24

Salute-Eva mentioned this pull request Aug 21, 2024

Release by 21.08.2024 #1382

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plasma-themes): Add fallback tokens for `plasma-themes` #1355

feat(plasma-themes): Add fallback tokens for `plasma-themes` #1355

neretin-trike commented Aug 13, 2024 •

edited by Salute-Eva

Loading

github-actions bot commented Aug 13, 2024

github-actions bot commented Aug 13, 2024

github-actions bot commented Aug 13, 2024

github-actions bot commented Aug 15, 2024

github-actions bot commented Aug 16, 2024

github-actions bot commented Aug 16, 2024

feat(plasma-themes): Add fallback tokens for plasma-themes #1355

feat(plasma-themes): Add fallback tokens for plasma-themes #1355

Conversation

neretin-trike commented Aug 13, 2024 • edited by Salute-Eva Loading

Tokens

What/why changed

github-actions bot commented Aug 13, 2024

github-actions bot commented Aug 13, 2024

github-actions bot commented Aug 13, 2024

⚡ Component performance testing

github-actions bot commented Aug 15, 2024

⚡ Component performance testing

github-actions bot commented Aug 16, 2024

⚡ Component performance testing

github-actions bot commented Aug 16, 2024

⚡ Component performance testing

feat(plasma-themes): Add fallback tokens for `plasma-themes` #1355

feat(plasma-themes): Add fallback tokens for `plasma-themes` #1355

neretin-trike commented Aug 13, 2024 •

edited by Salute-Eva

Loading