Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-new-hope: add portal prop to Autocomplete #1347

Merged
merged 3 commits into from
Aug 9, 2024
Merged

plasma-new-hope: add portal prop to Autocomplete #1347

merged 3 commits into from
Aug 9, 2024

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Aug 7, 2024 •
edited by Salute-Eva
Loading

Autocomplete

  • добавлено свойство portal
  • обновлена документация

What/why changed

Свойство portal реализовано аналогично тому, как это сделано в Dropdown

Without portal:

withoutPortal.mov

With portal:

withPortal.mov
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1347/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1347/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1347/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1347/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1347/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1347/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1347/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1347/sdds-dfa-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1347/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1347/ui-storybook/

@denivladislav denivladislav self-assigned this Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav marked this pull request as ready for review August 7, 2024 10:27
@vadim-kudr
Copy link
Contributor

может тест добавить?

@denivladislav denivladislav force-pushed the PLASMA-3322/add-portal-prop-to-autocomplete branch from 1a878aa to 03cdabc Compare August 7, 2024 14:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav force-pushed the PLASMA-3322/add-portal-prop-to-autocomplete branch from 03cdabc to 53a1e3b Compare August 9, 2024 06:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

⚡ Component performance testing

Result: 🟢 OK

@denivladislav denivladislav added this pull request to the merge queue Aug 9, 2024
Merged via the queue into dev with commit 6f37f67 Aug 9, 2024
30 checks passed
@denivladislav denivladislav deleted the PLASMA-3322/add-portal-prop-to-autocomplete branch August 9, 2024 07:25
@Salute-Eva Salute-Eva mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuga2704 shuga2704 shuga2704 approved these changes

@vadim-kudr vadim-kudr vadim-kudr approved these changes

Assignees

@denivladislav denivladislav

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denivladislav @vadim-kudr @shuga2704