Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-*: Add Portal component #1272

Merged
merged 7 commits into from
Jul 1, 2024
Merged

plasma-*: Add Portal component #1272

merged 7 commits into from
Jul 1, 2024

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Jun 28, 2024 •
edited by Salute-Eva
Loading

Portal

  • компонент добавлен в plasma-new-hope, портирован в plasma-{web, b2c}, caldera, sdds
  • добавлены тесты и документация
  • компонент внедрён в Popover и Popup
  • исправлено имя теста для Popover

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@denivladislav denivladislav self-assigned this Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1272/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1272/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1272/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1272/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1272/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1272/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1272/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1272/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1272/ui-storybook/

@denivladislav denivladislav marked this pull request as ready for review June 28, 2024 12:09
@denivladislav denivladislav requested review from iljs and removed request for Yeti-or, neretin-trike, TitanKuzmich and shuga2704 June 28, 2024 12:10
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich
Copy link
Contributor

Раз выносим портал в отдельный компонент, добавь его в поставку sdds-serv, caldera-online

@denivladislav denivladislav force-pushed the PLASMA-2766/add-portal-component branch from a5b8f70 to b9d943d Compare June 28, 2024 13:45
@TitanKuzmich
Copy link
Contributor

Добавь еще доку для caldera-online

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc changed the title plasma-{new-hope, b2c, web}, caldera, sdds: add Portal component plasma-*: Add Portal component Jul 1, 2024
@Yakutoc Yakutoc force-pushed the PLASMA-2766/add-portal-component branch from a8a4117 to 703db34 Compare July 1, 2024 10:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc added this pull request to the merge queue Jul 1, 2024
Merged via the queue into dev with commit ea2bc74 Jul 1, 2024
29 checks passed
@Yakutoc Yakutoc deleted the PLASMA-2766/add-portal-component branch July 1, 2024 11:24
@Salute-Eva Salute-Eva mentioned this pull request Jul 11, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@iljs iljs iljs approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

Assignees

@denivladislav denivladislav

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denivladislav @TitanKuzmich @Yakutoc @iljs