Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release by 29.05.2024 #1222

Merged
merged 60 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
8867e1c
feat(plasma-tokens): add surface transparent tokens
TitanKuzmich May 16, 2024
e266fde
feat(themes): add surface transparent tokens to sdds
TitanKuzmich May 16, 2024
26b093c
Update versions
Salute-Eva May 16, 2024
8b9e9ae
Update package-lock.json files
Salute-Eva May 16, 2024
4831a17
feat(plasma-new-hope): add edge dates control for Calendar
TitanKuzmich May 6, 2024
a8ca402
feat(plasma-web/b2c): update Calendar stories
TitanKuzmich May 6, 2024
31e6bd9
Update versions
Salute-Eva May 16, 2024
e38d594
Update package-lock.json files
Salute-Eva May 16, 2024
8a66e08
feat(perftest-helpers): add message for broken perftests
akhdrv May 17, 2024
f57221c
Update versions
Salute-Eva May 21, 2024
367d587
chore(scaffold): refactoring
Yakutoc Apr 26, 2024
a2f52d1
fix(docs): improved docs template
Yakutoc Apr 26, 2024
bdc60cd
docs(sdds-serv): popup fix
Yakutoc May 17, 2024
a23daae
Update versions
Salute-Eva May 22, 2024
9bc379f
Update package-lock.json files
Salute-Eva May 22, 2024
81f33d4
Update package-lock.json files
Salute-Eva May 10, 2024
0fae6f4
feat(plasma-new-hope): add react-draggable
TitanKuzmich May 13, 2024
5d16565
Update versions
Salute-Eva May 23, 2024
9316b74
Update package-lock.json files
Salute-Eva May 23, 2024
feda667
fix(new-hope): Textarea fix padding and label
iljs May 20, 2024
fe03a80
Update versions
Salute-Eva May 23, 2024
98cc2a9
Update package-lock.json files
Salute-Eva May 23, 2024
7beae3c
feat(plasma-new-hope): add Range component
TitanKuzmich May 14, 2024
4fde448
feat(plasma-b2c): add Range & write tests
TitanKuzmich May 15, 2024
d4e2df2
feat(plasma-web): add Range & write tests
TitanKuzmich May 16, 2024
ee6bbcf
docs: add Range docs
TitanKuzmich May 16, 2024
a3cb129
docs: regenerate api reports
TitanKuzmich May 16, 2024
3922161
test(plasma-web/b2c): add snapshots for Range
TitanKuzmich May 16, 2024
21ba1a8
feat(sdds-serv): add Range component
TitanKuzmich May 15, 2024
4b8a031
feat(plasma-web/b2c): add textfield label as controlled prop in stories
TitanKuzmich May 21, 2024
617fdd8
Update versions
Salute-Eva May 27, 2024
e58b080
Update package-lock.json files
Salute-Eva May 27, 2024
4b64c19
build: update perftool
akhdrv May 26, 2024
b6c9901
docs(sdds-serv-docs): add IconButtonDocs
TitanKuzmich May 22, 2024
6ec4df6
docs: regenerate api reports
TitanKuzmich May 22, 2024
1c6a9a8
feat(sdds-serv): add IconButton
TitanKuzmich May 22, 2024
d8c6c0f
Update versions
Salute-Eva May 28, 2024
ece0bdc
Update package-lock.json files
Salute-Eva May 28, 2024
bd0724a
docs: fix Segment & Tabs docs
TitanKuzmich May 27, 2024
985c117
feat(plasma-new-hope): fix tabs className forward & hide scrollbar
TitanKuzmich May 27, 2024
9252836
Update versions
Salute-Eva May 28, 2024
c00640c
Update package-lock.json files
Salute-Eva May 28, 2024
b6ed5bf
fix(components): fix checkbox types (sdds-serv, caldera-online, plasm…
iljs May 24, 2024
0588391
Update versions
Salute-Eva May 28, 2024
5a1eaa6
Update package-lock.json files
Salute-Eva May 28, 2024
34c397a
chore(docs-ui): npm audit fix
Yakutoc May 29, 2024
7f32db3
chore(cy-utils): npm audit fix
Yakutoc May 23, 2024
2a3eb95
feat(plasma-new-hope): add Button value
TitanKuzmich May 20, 2024
72ec28c
feat(plasma-web/b2c): update config, stories, tests for Button
TitanKuzmich May 20, 2024
0296e5a
feat(plasma-asdk): update config, stories for Button
TitanKuzmich May 20, 2024
4ea07de
feat(caldera-online): update config, stories for Button
TitanKuzmich May 20, 2024
4c22a3d
docs: regenerate api reports
TitanKuzmich May 20, 2024
716b262
docs: update docs for Button
TitanKuzmich May 20, 2024
797840c
test(plasma-web/b2c): update snapshots for Button
TitanKuzmich May 20, 2024
b285b72
fix(plasma-new-hope): fix ButtonGroup config & stories
TitanKuzmich May 20, 2024
3d4ac1d
fix(plasma-web/b2c,sdds-serv): fix configs & stories depending on Button
TitanKuzmich May 20, 2024
56d0575
test(plasma-web/b2c): update test depending on Button
TitanKuzmich May 20, 2024
a558fbf
feat(sdds-serv): update config and stories for Button
TitanKuzmich May 20, 2024
8e6a8e6
Update versions
Salute-Eva May 29, 2024
3c8f07a
Update package-lock.json files
Salute-Eva May 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions actions/perftest-helpers/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@salutejs/perftest-helpers",
"version": "0.4.0",
"version": "0.5.0-dev.0",
"description": "Performance test job helpers",
"author": "Salute Frontend Team <[email protected]>",
"license": "MIT",
Expand Down Expand Up @@ -37,4 +37,4 @@
"lib",
"actions"
]
}
}
14 changes: 14 additions & 0 deletions actions/perftest-helpers/src/modules/writeComment.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,16 @@ describe('perftest/writeComment', () => {

describe('getCommentBody', () => {
const descriptionResult = 'description';
const errorMessage = 'description';
let getDescriptionMock: jest.Mock;
let getErrorMessageMock: jest.Mock;

class ApiWithGetVisualReportExposed extends PerftestWriteCommentApi {
public getCommentBody = super.getCommentBody;

getReportDescription = (getDescriptionMock = jest.fn().mockReturnValue(descriptionResult) as any);

getErrorMessage = (getErrorMessageMock = jest.fn().mockReturnValue(errorMessage) as any);
}

it('should create report markup, add description', () => {
Expand All @@ -95,6 +99,16 @@ describe('perftest/writeComment', () => {
const result = api.getCommentBody(jsonReport as any);
expect(result.includes('OK')).toBe(true);
});

it('should write fallback message if no json report presented', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ого у нас есть тесты на экшоны

const jsonReport = null;
const api = new ApiWithGetVisualReportExposed({} as any);

const result = api.getCommentBody(jsonReport);
expect(result).toEqual(errorMessage);

expect(getErrorMessageMock).toHaveBeenCalledTimes(1);
});
});

describe('getReportDescription', () => {
Expand Down
19 changes: 17 additions & 2 deletions actions/perftest-helpers/src/modules/writeComment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class PerftestWriteCommentApi {
}

async post({ prId, owner, repo, reportPath }: WriteCommentParams): Promise<void> {
const jsonReport = await readJson<ReportType>(path.resolve(reportPath));
const jsonReport = await readJson<ReportType>(path.resolve(reportPath)).catch(() => null);
const body = this.getCommentBody(jsonReport);

await this.deps.octokit.rest.issues.createComment({
Expand All @@ -36,7 +36,11 @@ class PerftestWriteCommentApi {
});
}

protected getCommentBody(jsonReport: ReportType): string {
protected getCommentBody(jsonReport: ReportType | null): string {
if (!jsonReport) {
return this.getErrorMessage();
}

const result = jsonReport.hasSignificantNegativeChanges ? '🔴 FAIL' : '🟢 OK';

const report = `<h3>⚡ Component performance testing</h3>
Expand All @@ -49,6 +53,17 @@ ${this.getReportDescription(jsonReport)}
return report;
}

protected getErrorMessage(): string {
return `<h3>⚡ Component performance testing</h3>

**Result:** 💀 WASTED

Performance tests are broken.
If the current changes are the cause, please fix it immediately in this PR. If not, please schedule their repair.
For any questions, come to the Speed team.
`;
}

protected getReportDescription(jsonReport: ReportType): string {
const resultByTaskId = this.getResultByTaskId(jsonReport);
const metricsReport = this.getDescriptionTables(resultByTaskId);
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading