Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-new-hope): fix tabs styles #1220

Merged
merged 2 commits into from
May 28, 2024
Merged

feat(plasma-new-hope): fix tabs styles #1220

merged 2 commits into from
May 28, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented May 27, 2024 •
edited by Yakutoc
Loading

Tabs

  • добавлен корректный проброс className в Tab и TabItem
  • поправлена документация для Tab и Segment

ДО:

image
image

ПОСЛЕ:

image
image

What/why changed

В Tab и TabItem некорректно пробрасывался className, поэтому нельзя было оборачивать компонент в styled. Помимо этого в документации некорректно визуально отображались табы и сегменты

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this May 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1220/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1220/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1220/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1220/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1220/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1220/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1220/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1220/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1220/ui-storybook/

shuga2704
shuga2704 reviewed May 27, 2024
View reviewed changes
packages/plasma-new-hope/src/components/Segment/Segment.template-doc.mdx
<SegmentProvider>
<SegmentTemplate/>
</SegmentProvider>
<div style={{ display: "block" }} >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем display?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По умолчанию на первый дивак вешается flex и gap=1

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2944/fix-tabs-styles branch from 29510c8 to eac7747 Compare May 28, 2024 08:56
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue May 28, 2024
Merged via the queue into dev with commit 985c117 May 28, 2024
29 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2944/fix-tabs-styles branch May 28, 2024 09:51
@Salute-Eva Salute-Eva mentioned this pull request May 29, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuga2704 shuga2704 shuga2704 approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanKuzmich @neretin-trike @shuga2704