Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add button value #1213

Merged
merged 11 commits into from
May 29, 2024
Merged

feat: add button value #1213

merged 11 commits into from
May 29, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented May 20, 2024 •
edited by Salute-Eva
Loading

Button

  • добавлено отображение value
  • исправлены внутренние отступы от contentLeft, contentRight
  • дополнены тесты и документация
  • исправлены тесты, зависящие от Button: Notification, Pagination, Toast, Toolbar
  • добавлен токен переопределения цвета value в ButtonGroup

What/why changed

Добавлено отображение value в Button согласно макетам.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this May 20, 2024
@TitanKuzmich TitanKuzmich requested review from iljs and Irinkv and removed request for Yeti-or and Yakutoc May 20, 2024 12:57
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1213/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1213/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1213/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1213/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1213/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1213/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1213/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1213/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1213/ui-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2816/add-button-value branch from de6c709 to 0401120 Compare May 20, 2024 16:00
@TitanKuzmich TitanKuzmich force-pushed the plasma-2816/add-button-value branch from 0401120 to 3a4cfde Compare May 20, 2024 16:07
@TitanKuzmich TitanKuzmich force-pushed the plasma-2816/add-button-value branch from 3a4cfde to 442d3d2 Compare May 20, 2024 16:13
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2816/add-button-value branch from f9b5e71 to 6df6b9f Compare May 29, 2024 07:47
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue May 29, 2024
Merged via the queue into dev with commit a558fbf May 29, 2024
29 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2816/add-button-value branch May 29, 2024 08:39
@Salute-Eva Salute-Eva mentioned this pull request May 29, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irinkv Irinkv Irinkv approved these changes

@shuga2704 shuga2704 shuga2704 approved these changes

@iljs iljs iljs approved these changes

@neretin-trike neretin-trike Awaiting requested review from neretin-trike neretin-trike is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TitanKuzmich @Yeti-or @iljs @shuga2704 @Irinkv