feat(plasma-tokens): Add write / read and generation new format of theme.json #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neretin-trike
requested review from
Yeti-or,
Yakutoc,
TitanKuzmich and
shuga2704
as code owners
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1207/ |
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 20, 2024
website/plasma-theme-builder/src/_new/tokens/fontFamily/default/android.ts
Show resolved
Hide resolved
Yakutoc
reviewed
May 20, 2024
website/plasma-theme-builder/src/_new/tokens/fontFamily/fontFamily.ts
Outdated
Show resolved
Hide resolved
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 20, 2024
Yakutoc
reviewed
May 21, 2024
Yakutoc
reviewed
May 21, 2024
website/plasma-theme-builder/src/_new/themes/createMetaTokens.ts
Outdated
Show resolved
Hide resolved
Yakutoc
reviewed
May 21, 2024
website/plasma-theme-builder/src/_new/themes/createMetaTokens.ts
Outdated
Show resolved
Hide resolved
Yakutoc
reviewed
May 21, 2024
Yakutoc
reviewed
May 21, 2024
Yakutoc
reviewed
May 21, 2024
Yakutoc
reviewed
May 21, 2024
Yakutoc
reviewed
May 21, 2024
website/plasma-theme-builder/src/_new/examples/buildAndModifyMockTheme.ts
Show resolved
Hide resolved
Yeti-or
approved these changes
May 23, 2024
| return new ColorToken(token, values); | ||
| }); | ||
|
|
||
| const removeHoverAndActiveTokens = (token: TokenType) => |
There was a problem hiding this comment.
идея в том, чтобы при создании инстанса класса Theme не добавлять эти технические токены по следующим причинам:
- Они не используются в визуальном интерфейсе сервиса
- Они не будут занимать лишнюю память
- Их не нужно будет пересчитывать каждый раз при изменении "основного" токена, на котором основаны токены состояния active / hover
website/plasma-theme-builder/src/_new/tokens/typography/creators.ts
Outdated
Show resolved
Hide resolved
| const typography = createDefaultTypographyTokens(config); | ||
| const fontFamily = createDefaultFontFamilyTokens(config); | ||
|
|
||
| return new Theme(config.name, '0.1.0', { |
There was a problem hiding this comment.
это версия базовой темы. Т.е. когда пользователь создаёт свою тему, начинается отсчёт с версии 0.1.0
shuga2704
approved these changes
May 28, 2024
neretin-trike
force-pushed
the
neretinaa/add-new-scheme-generation
branch
from
a551fc9 to
39d3e6d
Compare
- @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected] - @salutejs/[email protected]
neretin-trike
force-pushed
the
neretinaa/add-new-scheme-generation
branch
from
39d3e6d to
79a8f6b
Compare
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theme
What/why changed
Пример диаграммы зависимостей для токена типа
color.Более подробное описание всех добавленных изменений.