Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add calendar edge dates control #1203

Merged
merged 2 commits into from
May 16, 2024
Merged

feat: add calendar edge dates control #1203

merged 2 commits into from
May 16, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented May 6, 2024 •
edited by Salute-Eva
Loading

Calendar

  • добавлен пропс для включения/исключения минимума и максимума диапазона дат

What/why changed

Появился запрос на выбор крайних дат диапазона. Изначально было нестрогое сравнение на выход за границы периода из-за чего крайние значения были недоступны. Пример: min=7 max=15, при этом числа доступные для выбора 7 < x < 15

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this May 6, 2024
@TitanKuzmich TitanKuzmich removed request for Yeti-or and Yakutoc May 6, 2024 13:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1203/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1203/
caldera-online storybook: https://plasma.sberdevices.ru/pr/pr-1203/caldera-online-storybook/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1203/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1203/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1203/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1203/web-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1203/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1203/ui-storybook/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc
Copy link
Collaborator

Yakutoc commented May 13, 2024

@TitanKuzmich

А может в тестах тоже отобразим проверку нового свойства?

Новое свойство не сломало ничего в a11y?

@TitanKuzmich TitanKuzmich force-pushed the plasma-2830/add-calendar-edge-dates-control branch from 23cb2ab to c8617ce Compare May 15, 2024 08:02
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2830/add-calendar-edge-dates-control branch from c8617ce to 410bcc8 Compare May 16, 2024 11:44
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2830/add-calendar-edge-dates-control branch from 410bcc8 to 11fb36e Compare May 16, 2024 13:35
@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue May 16, 2024
Merged via the queue into dev with commit a8ca402 May 16, 2024
29 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2830/add-calendar-edge-dates-control branch May 16, 2024 14:22
@Salute-Eva Salute-Eva mentioned this pull request May 29, 2024
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuga2704 shuga2704 shuga2704 approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

@neretin-trike neretin-trike Awaiting requested review from neretin-trike neretin-trike is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanKuzmich @Yakutoc @shuga2704