plasma-infra: Fix publish rc #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yakutoc
commented
Mar 22, 2024
|
|
||
| ## Высчитываем условие для загрузки assets | ||
| - name: Computed scope state | ||
| id: scope | ||
| uses: actions/github-script@v6 | ||
| env: | ||
| CHANGED_STATE: ${{ toJSON(steps.lerna_ls.outputs.STATE) }} | ||
| RAW_DATA: ${{ steps.lerna_ls.outputs.RAW_DATA }} |
There was a problem hiding this comment.
[Note]:
В processing-scope.js ожидалась переменная RAW_DATA без обертки toJSON
|
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1143/ |
Yakutoc
commented
Mar 22, 2024
| if: ${{ always() && contains(needs.*.result, 'failure') }} | ||
| env: | ||
| FAILED_JOB_NAME: ${{ contains(needs.change-state.result, 'failure') && 'Save state' || 'Publish RC version / publish' }} | ||
| FAILED_JOB_NAME: ${{ contains(needs.change-state.result, 'failure') && 'State' || 'Publish RC version / publish' }} |
There was a problem hiding this comment.
[Note]:
[Handle errors]
Unhandled error: TypeError: Cannot read properties of undefined (reading 'find')
Потому что имя job === "State" а не "Save state"
Это bug причем очень старый - копипаста из песочницы. (
У нас не стрелял по причине того что никогда первая job не падала.
Yakutoc
commented
Mar 22, 2024
Yakutoc
requested review from
Yeti-or,
neretin-trike and
kayman233
as code owners
neretin-trike
approved these changes
Mar 22, 2024
Yakutoc
force-pushed
the
ci-fix-publish-rc
branch
from
3d2af3d to
a3b88b2
Compare
Yeti-or
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/why changed
В workflow для публикации релиз кандидата забыл
process-scope.js📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: