plasma-infra: Refactoring deploy documentations artefacts [PR context] #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yakutoc
force-pushed
the
ci-refactoring-deploy-docs
branch
from
089f81f to
8888353
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1125/ |
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1125/ |
Yakutoc
commented
Mar 18, 2024
Yakutoc
force-pushed
the
ci-refactoring-deploy-docs
branch
from
8888353 to
a7cdda5
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1125/ |
Yakutoc
commented
Mar 18, 2024
Yakutoc
requested review from
Yeti-or,
malilex,
neretin-trike and
kayman233
as code owners
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1125/ |
neretin-trike
approved these changes
Mar 20, 2024
Yakutoc
force-pushed
the
ci-refactoring-deploy-docs
branch
from
494b913 to
acf7c49
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1125/ |
Yeti-or
approved these changes
Mar 20, 2024
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "PACKAGES_CYPRESS": ["plasma-web", "plasma-b2c", "plasma-ui"], | |||
| "PACKAGES_DS": [ | |||
There was a problem hiding this comment.
@Yeti-or design system типа вертикаль.
There was a problem hiding this comment.
не, это не вертикали же. Это именно библиотеки
Merged
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy documentations artefacts
marocchino/sticky-pull-request-commentдля приклеивания сообщения к одному комментарию в prconfig-ci.jsonWhat/why changed
При увеличении кол-ва клиентских пакетов будет расти время загрузки артефактов документации.
Уже сейчас время на загрузку для всех пакетов составляет: от
20 minдо30 min.Поэтом решили делать параллельные job сборки документации (нечто подобное делаем для запуска тестов Cypress)
Плюсы:
Минусы:
Файл конфигурации CI:
config-ci.jsonОписывает:
cypressтестыДоводы ЗА файл конфигурации
vars. PACKAGES_DS)Lernaпредоставляет состояние измененных пакетов на основе которого высчитывается для каких пакетов из конфигурации нужно собрать и загрузить артефакты документации.Сборка plasma-web (storybook + docs): 13m 31s
Сборка plasma-asdk (storybook): 8m 21s
Сборка всех пакетов (storybook + docs): 16m 52s
Проверена сборка для: