Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-infra: Plasma-icons delete dep plasma-core #1106

Merged
merged 2 commits into from
Mar 14, 2024
Merged

plasma-infra: Plasma-icons delete dep plasma-core #1106

merged 2 commits into from
Mar 14, 2024

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Mar 12, 2024 •
edited by Salute-Eva
Loading

Icons

  • убрали зависимость plasma-core и заменили на plain value: var(--plasma-colors-primary)
  • поставили версию 5.1.0 для @types/styled-components (в клиентских пакетах именно такая)

What/why changed

npx lerna bootstrap --scope="@salutejs/{plasma-new-hope,plasma-web-docs,plasma-web,plasma-docs-ui}"

при сборке документации для plasma-web-docs упадет с ошибкой:

Error:  Client bundle compiled with errors therefore further build is impossible.
Module not found: Error: Can't resolve '@salutejs/plasma-core' in '/home/runner/work/DEV_STAGE/DEV_STAGE/website/plasma-web-docs/node_modules/@salutejs/plasma-icons/es'
Module not found: Error: Can't resolve '@salutejs/plasma-core' in '/home/runner/work/DEV_STAGE/DEV_STAGE/website/plasma-web-docs/node_modules/@salutejs/plasma-icons/es/scalable'
Error: Process completed with exit code 1.

Причина

В пакете plasma-icons используется @salutejs/plasma-core как peerDependencies и devDependencies:

import { primary } from '@salutejs/plasma-core';

И это требует "принято решение" что сделать в пакете plasma-web-docs:

  • указать явно в dependencies этот же пакет

или

  • убрать зависимость на уровне самого plasma-icons

Второй пункт ИМХО самый простой.

С ним не придется делать дополнительных телодвижений.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc added plasma-infra changelog-skip Exclude pull request changes from changelog labels Mar 12, 2024
@Yakutoc Yakutoc self-assigned this Mar 12, 2024
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1106/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1106/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1106/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1106/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1106/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1106/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1106/sdds-serv-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc marked this pull request as ready for review March 12, 2024 07:14
@Yakutoc Yakutoc removed the request for review from kayman233 March 12, 2024 07:14
@Yakutoc Yakutoc changed the title plasma-infra: WIP plasma-infra: Plasma-icons delete dep plasma-core Mar 12, 2024
@Yakutoc Yakutoc requested a review from TitanKuzmich March 14, 2024 09:07
@Yakutoc Yakutoc force-pushed the chore-icons-delete-core-dep branch from 28b1500 to 32643f9 Compare March 14, 2024 10:23
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1106/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1106/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1106/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1106/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1106/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1106/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1106/sdds-serv-storybook/

@Yakutoc Yakutoc force-pushed the chore-icons-delete-core-dep branch from 32643f9 to a0df0c3 Compare March 14, 2024 10:45
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1106/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1106/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1106/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1106/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1106/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1106/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1106/sdds-serv-storybook/

@Yakutoc Yakutoc force-pushed the chore-icons-delete-core-dep branch from a0df0c3 to f73c782 Compare March 14, 2024 11:18
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1106/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-1106/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-1106/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-1106/web-storybook/
ui storybook: http://plasma.sberdevices.ru/pr/pr-1106/ui-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-1106/asdk-storybook/
sdds-serv storybook: http://plasma.sberdevices.ru/pr/pr-1106/sdds-serv-storybook/

@Yakutoc Yakutoc added this pull request to the merge queue Mar 14, 2024
Merged via the queue into dev with commit 80900a3 Mar 14, 2024
25 checks passed
@Yakutoc Yakutoc deleted the chore-icons-delete-core-dep branch March 14, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

Assignees

@Yakutoc Yakutoc

Labels
changelog-skip Exclude pull request changes from changelog plasma-infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yakutoc @Salute-Eva @Yeti-or @neretin-trike @TitanKuzmich