Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plasma-new-hope): Fixes for TextArea component #1017

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

neretin-trike
Copy link
Collaborator

@neretin-trike neretin-trike commented Jan 30, 2024

TextArea

  • Добавлена поддержка переноса строки для свойства placeholder;
  • Исправлено поведение компонента при использовании свойств defaultValue и placeholder.

What/why changed

Ранее palceholder не переносился на следующую строку:

image

При использовании свойства defaultValue , значение плейсхолдера накладывалось

image
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1017/

@neretin-trike neretin-trike requested review from TitanKuzmich and shuga2704 and removed request for Yeti-or January 31, 2024 06:26
@neretin-trike neretin-trike added this pull request to the merge queue Jan 31, 2024
Merged via the queue into dev with commit 5638ccd Jan 31, 2024
27 checks passed
@neretin-trike neretin-trike deleted the neretinaa/fix-textarea-placeholder branch January 31, 2024 07:38
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

This was referenced Jan 31, 2024
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

This was referenced Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants