fix(plasma-new-hope): fix id generation for Modal, Popup

salute-developers · Jan 25, 2024 · 092a661 · 092a661
1 parent 0ad715e
commit 092a661
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/plasma-new-hope/src/components/Modal/Modal/Modal.tsx b/packages/plasma-new-hope/src/components/Modal/Modal/Modal.tsx
@@ -1,5 +1,5 @@
 import React, { forwardRef } from 'react';
-import { useFocusTrap, useForkRef, useUniqId } from '@salutejs/plasma-core';
+import { useFocusTrap, useForkRef, safeUseId } from '@salutejs/plasma-core';
 
 import { RootProps, component } from '../../../engines';
 import { popupConfig } from '../../Popup';
@@ -43,14 +43,14 @@ export const modalRoot = (Root: RootProps<HTMLDivElement, ModalProps>) =>
 
             const innerRef = useForkRef<HTMLDivElement>(trapRef, outerRootRef);
 
-            const uniqId = useUniqId();
+            const uniqId = safeUseId();
             const innerId = id || uniqId;
 
             const { modalInfo } = useModal({ id: innerId, isOpen, closeOnEsc, onEscKeyDown, onClose, popupInfo });
 
             return (
                 <Popup
-                    id={id}
+                    id={innerId}
                     isOpen={isOpen}
                     ref={innerRef}
                     popupInfo={modalInfo}

diff --git a/packages/plasma-new-hope/src/components/Popup/Popup.tsx b/packages/plasma-new-hope/src/components/Popup/Popup.tsx
@@ -1,6 +1,6 @@
 import React, { forwardRef, useEffect, useRef, useState } from 'react';
 import ReactDOM from 'react-dom';
-import { useForkRef, useUniqId } from '@salutejs/plasma-core';
+import { useForkRef, safeUseId } from '@salutejs/plasma-core';
 
 import { RootProps } from '../../engines/types';
 import { cx } from '../../utils';
@@ -101,7 +101,7 @@ export const popupRoot = (Root: RootProps<HTMLDivElement, PopupProps>) =>
             },
             outerRootRef,
         ) => {
-            const uniqId = useUniqId();
+            const uniqId = safeUseId();
             const innerId = id || uniqId;
 
             const { isVisible, animationInfo, setVisible } = usePopup({