feat(sdds-counter): added sdds-counter #137
Conversation
VladimirDimitraki
requested review from
vkaltyrin and
malilex
as code owners
VladimirDimitraki
temporarily deployed
to
sdds
GitHub Actions
Inactive
VladimirDimitraki
temporarily deployed
to
sdds
GitHub Actions
Inactive
| } | ||
| .background(currentColor(for: appearance.backgroundColor)) | ||
| .cornerRadius(cornerRadius) | ||
| .frame(maxWidth: data.value.count > 1 ? .infinity : appearance.size.width, minHeight: appearance.size.height) |
There was a problem hiding this comment.
@VladimirDimitraki Давай вот эту штуку data.value.count > 1 ? .infinity : appearance.size.width вынесем в отдельный computed property
| if let typography = appearance.dataTypography.typography(with: appearance.size) { | ||
| return typography | ||
| } else { | ||
| fatalError("Undefined Button Typography for size \(appearance.size.debugDescription). Using a default value.") |
There was a problem hiding this comment.
"Undefined Counter Typography for size \(appearance.size.debugDescription). Using a default value."
Можно кстати вынести всю эту строку в отдельную функцию в extension для View, вроде
extension View {
func undefinedTypographyErrorText(sizeDescription: String) -> String {
"Undefined \(Self.self) Typography for size \(sizeDescription). Using a default value."
}
}
и вызвать
fatalError(undefinedTypographyErrorText(sizeDescription: appearance.size.debugDescription))
| public var body: some View { | ||
| List { | ||
| counterView | ||
|
|
There was a problem hiding this comment.
@VladimirDimitraki Давай уберем переход на новую строку
|
|
||
| Section { | ||
| dataTextField | ||
|
|
There was a problem hiding this comment.
не нужен переход на новую строку
| dataTextField | ||
|
|
||
| appearance | ||
|
|
There was a problem hiding this comment.
не нужен переход на новую строку
|
|
||
| public var body: some View { | ||
| ZStack { | ||
| if data.value.count > 1 { |
There was a problem hiding this comment.
@VladimirDimitraki data.value.count > 1 вот эту штуку лучше вынести в computer property и назвать например var isAuto: Bool
| } | ||
|
|
||
| public var counterAutomationSize: some View { | ||
| Text("\(data.value)") |
There was a problem hiding this comment.
@VladimirDimitraki "\(data.value)" вот эту штуку можно вынести в computer property var text: String и переиспользовать везде
VladimirDimitraki
force-pushed
the
feature/vsdimitraki/components-counter
branch
from
b5ee157 to
4c90ff5
Compare
VladimirDimitraki
temporarily deployed
to
sdds
GitHub Actions
Inactive
VladimirDimitraki
temporarily deployed
to
sdds
GitHub Actions
Inactive
| @@ -16,4 +16,8 @@ public extension View { | |||
| func gradient(_ token: GradientToken, colorScheme: ColorScheme = .light) -> some View { | |||
| modifier(GradientModifier(token: token, colorScheme: colorScheme)) | |||
| } | |||
|
|
|||
| func undefinedTypographyErrorText(sizeDescription: String) -> String { | |||
There was a problem hiding this comment.
@VladimirDimitraki Давай лучше заведем extension именно в SDDSComponents, поскольку этот метод будет использоваться только там. Тем более – именно этот extension (SDDSThemeBuilder/SDDSThemeCore/Sources/SDDSThemeCore/Extensions/View+Tokens.swift) используется только модификаторов токенов, а не для функций-утилит
| } | ||
|
|
||
| var dynamicWidth: CGFloat { | ||
| data.value.count > 1 ? .infinity : appearance.size.width |
There was a problem hiding this comment.
@VladimirDimitraki здесь можно использовать isAuto
VladimirDimitraki
temporarily deployed
to
sdds
GitHub Actions
Inactive
VladimirDimitraki
had a problem deploying
to
sdds
GitHub Actions
Failure
vkaltyrin
force-pushed
the
feature/vsdimitraki/components-counter
branch
from
e6e28e4 to
39fe2b1
Compare
Release/25 12 2024
VladimirDimitraki
force-pushed
the
feature/vsdimitraki/components-counter
branch
from
9f364cb to
6fef021
Compare
VladimirDimitraki
force-pushed
the
feature/vsdimitraki/components-counter
branch
from
c7a39ff to
8377aa6
Compare
VladimirDimitraki
force-pushed
the
feature/vsdimitraki/components-counter
branch
from
8377aa6 to
85c6e7c
Compare
VladimirDimitraki
temporarily deployed
to
sdds
GitHub Actions
Inactive
VladimirDimitraki
had a problem deploying
to
sdds
GitHub Actions
Failure
No description provided.