Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdds-acore/uikit): Component Counter was added #231

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(sdds-acore/uikit): Component Counter was added #231

wants to merge 1 commit into from

Conversation

SerraMorec
Copy link
Collaborator

@SerraMorec SerraMorec commented Dec 24, 2024 •
edited
Loading

Снимок экрана 2024-12-25 в 05 32 33

@SerraMorec SerraMorec force-pushed the feature/component-counter branch from 3c64da4 to d8da466 Compare December 25, 2024 02:30
@SerraMorec SerraMorec requested a review from angirb December 25, 2024 03:42
raininforest
raininforest reviewed Dec 25, 2024
View reviewed changes
tokens/sdds.serv.view/src/main/res/color/bg_color_counter.xml
<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:tools="http://schemas.android.com/tools" xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" tools:ignore="ResourceName">

<item android:color="?serv_surfaceDefaultAccentActive" android:state_pressed="true" app:sd_state_accent="true" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а точно у каунтера есть pressed/hovered состояния?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я рассуждал по такому принципу - если counter в составе segmentItem, а у него есть такие состояния как pressed и hovered  то и counter должен так же их поддерживать, чтоб при нажатии на segmentItem так же что то поменялось и в counter. или я ошибаюсь?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

возможно ты прав. проверял, оно так работает?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

неа, чтоб проверить нужно каунтер в сегмент поместить

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raininforest raininforest raininforest left review comments

@angirb angirb angirb approved these changes

@malilex malilex Awaiting requested review from malilex malilex is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SerraMorec @raininforest @angirb