feat(eslint-config): refactor repo and update deps #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenykruglikov
force-pushed
the
update-eslint
branch
7 times, most recently
from
56a0949 to
6a17879
Compare
SeanSilke
reviewed
Sep 20, 2024
| "main": "index.js", | ||
| "dependencies": { | ||
| "@salutejs/eslint-config-base": "*", | ||
| "eslint-plugin-salute-rules": "*" |
There was a problem hiding this comment.
Было так.
"eslint-plugin-salute-rules": "file:./rules"
Теперь так
""eslint-plugin-salute-rules": "*"
There was a problem hiding this comment.
При сборке конфиг теперь не может найти, eslint-plugin-salute-rules .
Наверно правила нужно будет отдельно выложить, чтобы не возникло таких проблем в будущем.
arsenykruglikov
force-pushed
the
update-eslint
branch
2 times, most recently
from
7b79353 to
cf7748a
Compare
|
Давай правила тоже загоним по |
SeanSilke
approved these changes
Sep 24, 2024
arsenykruglikov
force-pushed
the
update-eslint
branch
from
cf7748a to
6a52ac5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
arsenykruglikov
force-pushed
the
update-eslint
branch
5 times, most recently
from
ded1ca3 to
538feea
Compare
arsenykruglikov
force-pushed
the
update-eslint
branch
3 times, most recently
from
2474491 to
7649487
Compare
arsenykruglikov
force-pushed
the
update-eslint
branch
from
7649487 to
c43bb74
Compare
arsenykruglikov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: