Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tauticord Role #255

Merged
merged 8 commits into from
Jun 16, 2023
Merged

Add Tauticord Role #255

merged 8 commits into from
Jun 16, 2023

Conversation

benwaco
Copy link
Contributor

@benwaco benwaco commented May 5, 2023

Requries configuration via config/config.yaml

Description

https://github.com/nwithan8/tauticord

Will update docs if merged.

How Has This Been Tested?

Tested on my server with my Plex server.

benwaco and others added 3 commits May 4, 2023 19:09
Requries configuration via
Minor formatting fixes
Delete extra blank line at end of file.
@maximuskowalski
Copy link
Collaborator

Edited some minor formatting but you also need to edit sandbox.yml to include the role. How did you test it without editing this file?
https://github.com/saltyorg/Sandbox/blob/master/sandbox.yml

See the examples there - fairly straightforward to include it.

@maximuskowalski maximuskowalski added the Traefik 3 T3 branch should include this if we have time. label May 5, 2023
@benwaco
Copy link
Contributor Author

benwaco commented May 5, 2023

Edited some minor formatting but you also need to edit sandbox.yml to include the role. How did you test it without editing this file? https://github.com/saltyorg/Sandbox/blob/master/sandbox.yml

See the examples there - fairly straightforward to include it.

Sorry, I edited the file on my MacBook and sftp'd it to my server. I changed the file on my server but forgot to commit it here. Will fix.

@saltydk
Copy link
Member

saltydk commented May 5, 2023

Volumes look wrong, two container paths mounted to the same host path.

@nwithan8
Copy link

nwithan8 commented May 6, 2023

Volumes look wrong, two container paths mounted to the same host path.

One volume expects a config.yaml file in it, the other will output a Tauticord.log file in it. Both volumes could be mapped to the same host path with no conflict.

@maximuskowalski
Copy link
Collaborator

tauticord_paths_config_location: "{{ tauticord_paths_location }}/config/config.yaml"

Would this be correct then?
If the config dir is mapped to eg /opt/tauticord then config file is expected to be found at /opt/tauticord/config/config.yml

@saltydk
Copy link
Member

saltydk commented May 6, 2023

Volumes look wrong, two container paths mounted to the same host path.

One volume expects a config.yaml file in it, the other will output a Tauticord.log file in it. Both volumes could be mapped to the same host path with no conflict.

Sure, I just think it is messy doing stuff like that. I'll leave that up to Max and Owine.

@saltydk
Copy link
Member

saltydk commented May 6, 2023

tauticord_paths_config_location: "{{ tauticord_paths_location }}/config/config.yaml"

Would this be correct then? If the config dir is mapped to eg /opt/tauticord then config file is expected to be found at /opt/tauticord/config/config.yml

The variable isn't used for anything as far as I can tell.

@nwithan8
Copy link

nwithan8 commented May 6, 2023

tauticord_paths_config_location: "{{ tauticord_paths_location }}/config/config.yaml"

Would this be correct then?
If the config dir is mapped to eg /opt/tauticord then config file is expected to be found at /opt/tauticord/config/config.yml

My apologies, no, that would be incorrect. It's expecting to find a config.yaml in whatever is mapped to the config folder. No sub-folders. I think I was looking at the wrong spot when addressing your comment.

@benwaco
Copy link
Contributor Author

benwaco commented May 24, 2023

Btw this is fixed now

add blank at end of file and new line between tasks.
Explicitly create config and logs referenced volumes to ensure correct permissions.
remove errant space
@maximuskowalski maximuskowalski merged commit 6bf6628 into saltyorg:master Jun 16, 2023
@maximuskowalski
Copy link
Collaborator

Will update docs if merged.

@benwaco

@maximuskowalski
Copy link
Collaborator

@benwaco There is someone with a problem on discord, not sure how to find you there. It looks like the config file is not being created?

"Before using this program, you must configure it. To do this, rename the file config.yaml.example in the {{ tauticord_paths_location }}/config directory to config.yaml and edit the file to your desired settings."

@nwithan8
Copy link

@benwaco There is someone with a problem on discord, not sure how to find you there. It looks like the config file is not being created?

"Before using this program, you must configure it. To do this, rename the file config.yaml.example in the {{ tauticord_paths_location }}/config directory to config.yaml and edit the file to your desired settings."

This should be fixed in v3.7.0 of Tauticord: https://github.com/nwithan8/tauticord/releases/tag/v3.7.0

@maximuskowalski
Copy link
Collaborator

Thanks! I have not installed to check it so had mostly assumed user error.

owine pushed a commit that referenced this pull request Aug 30, 2023
* Add Tauticord Role

Requries configuration via

* Update main.yml

Minor formatting fixes

* Update main.yml

Delete extra blank line at end of file.

* Update sandbox.yml

* Fix Tauticord Role

* Update main.yml

add blank at end of file and new line between tasks.

* Update main.yml

Explicitly create config and logs referenced volumes to ensure correct permissions.

* Update main.yml

remove errant space

---------

Co-authored-by: Max Kowalski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Traefik 3 T3 branch should include this if we have time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants