Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rpm_lowpkg version comparison logic when using rpm-vercmp #63849

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Mar 9, 2023

What does this PR do?

Fixes the logic when using rpm-vercmp and comparing the versions: ("3.23-6.el9", "3.23")

This also fixes this logic when using the cli tool rpmdev-vercmp. This was found when adding a test.

What issues does this PR fix or reference?

Fixes: #63317

Previous Behavior

>>> import salt.modules.rpm_lowpkg
>>> salt.modules.rpm_lowpkg.version_cmp("3.23-6.el9", "3.23")
1

New Behavior

>>> import salt.modules.rpm_lowpkg
>>> salt.modules.rpm_lowpkg.version_cmp("3.23-6.el9", "3.23")
0

@s0undt3ch
Copy link
Collaborator

GH Actions pipeline passed. Merging.

@s0undt3ch s0undt3ch merged commit 9242252 into saltstack:3006.x Mar 10, 2023
@Ch3LL Ch3LL mentioned this pull request Mar 10, 2023
garethgreenaway added a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants