Improve error reporting in cherrypy #63836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
previously approved these changes
Mar 7, 2023
anilsil
changed the title
|
@whytewolf Mind adding a test case verifying that we now see the message that we previously didn't? |
s0undt3ch
added
the
Needs-Testcase
no problem. test added. took a little longer than i wanted to do though. |
Ch3LL
previously approved these changes
Mar 9, 2023
twangboy
previously approved these changes
Mar 9, 2023
s0undt3ch
removed
the
Needs-Testcase
s0undt3ch
previously approved these changes
Mar 10, 2023
added 4 commits
March 10, 2023 07:30
…ing not setting netapi_clients setting
…when netwpi_client setting is not set
s0undt3ch
dismissed stale reviews from twangboy, Ch3LL, and themself
via
91a69d3
s0undt3ch
force-pushed
the
salt-api_errors
branch
from
4ad3181
to
91a69d3
Compare
|
Approved and tests are passing. Merging. |
garethgreenaway
added a commit
that referenced
this pull request
Mar 10, 2023
porting #63836 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes 400 error reporting in cherrypy to give users more context about issue.
What issues does this PR fix or reference?
Fixes: #63835
Previous Behavior
400 error was generic
New Behavior
adds exception message from exception that caused 400 to 400 error and log error.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No