Warn when using insecure key_urls on apt based systems #63004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rg to control whether they are allowed or not
cmcmarrow
previously approved these changes
Nov 3, 2022
|
Looks good, I restarted some tests for you. |
garethgreenaway
previously approved these changes
Nov 3, 2022
twangboy
previously approved these changes
Nov 3, 2022
Ch3LL
suggested changes
Nov 3, 2022
MKLeb
dismissed stale reviews from twangboy, garethgreenaway, and cmcmarrow
via
a0acdad
Ch3LL
approved these changes
Nov 3, 2022
cmcmarrow
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Warn when using insecure (http, not https) key_urls on apt based systems, and add a kwarg to control whether they are allowed or not. The kwarg will default to True until 3008, where it will transition to defaulting to false and logging a warning if set to True.
Also, indentaion in the documentation for
pkgrepo.managedwas fixed.What issues does this PR fix or reference?
Fixes: #59786
Previous Behavior
A
key_urlstarting withhttp:was handled like normal.New Behavior
A new kwarg,
allow_insecure_key, gates how we handlehttp:urls.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes