Update sanitizing masking for Salt SSH #62482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… additional password related keys.
twangboy
previously approved these changes
Aug 17, 2022
dmurphy18
previously approved these changes
Aug 17, 2022
garethgreenaway
dismissed stale reviews from dmurphy18 and twangboy
The base branch was changed.
Ch3LL
suggested changes
Aug 18, 2022
dmurphy18
reviewed
Aug 19, 2022
dmurphy18
approved these changes
Aug 19, 2022
Ch3LL
approved these changes
Aug 19, 2022
s0undt3ch
approved these changes
Aug 23, 2022
|
CI passing and 3 approvals, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removing unnecessary logging that could display sensitive data. Mask additional password related keys.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.