Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groups with duplicate GIDs are not returned by get_group_list #62378

Merged
merged 18 commits into from
Aug 8, 2022

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes: #62377

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner July 25, 2022 17:39
@nicholasmhughes nicholasmhughes requested review from ScriptAutomate and removed request for a team July 25, 2022 17:39
@nicholasmhughes nicholasmhughes added AIX affects this operating system Sulfur v3006.0 release code name and version and removed AIX affects this operating system labels Jul 25, 2022
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require a changelog, and there are some test failures that need cleaned up

Ch3LL
Ch3LL previously approved these changes Jul 26, 2022
@Ch3LL
Copy link
Contributor

Ch3LL commented Jul 26, 2022

There are a couple of remaining test failures on freebsd and mac that are related to this PR

@nicholasmhughes
Copy link
Collaborator Author

re-run pr-alma-8-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator Author

@waynew , any ideas as to why skipIf isn't working here?

@Ch3LL
Copy link
Contributor

Ch3LL commented Aug 1, 2022

I would try using @pytest.mark.skipif

@nicholasmhughes
Copy link
Collaborator Author

re-run pr-macosx-catalina-x86_64-py3-pytest

@nicholasmhughes
Copy link
Collaborator Author

re-run pr-freebsd-131-amd64-py3-pytest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] groups with duplicate GIDs are not returned by get_group_list
2 participants