-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pass renderer configurable & other fixes #62120
Merged
Ch3LL
merged 9 commits into
saltstack:master
from
dmach:make-pass-renderer-configurable
Sep 27, 2022
Merged
Make pass renderer configurable & other fixes #62120
Ch3LL
merged 9 commits into
saltstack:master
from
dmach:make-pass-renderer-configurable
Sep 27, 2022
Commits on Sep 22, 2022
-
pass: Use a secure way of handling pass arguments
The original code would fail on pass paths with spaces, because they would be split into multiple arguments.
Configuration menu - View commit details
-
Copy full SHA for d44f8b2 - Browse repository at this point
Copy the full SHA d44f8b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b453a0b - Browse repository at this point
Copy the full SHA b453a0bView commit details -
pass: Do not modify $HOME env globally
Just set $HOME for calling the pass binary to avoid affecting anything outside the pass renderer.
Configuration menu - View commit details
-
Copy full SHA for d60b22a - Browse repository at this point
Copy the full SHA d60b22aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9eed6da - Browse repository at this point
Copy the full SHA 9eed6daView commit details -
Make the pass renderer more configurable
1. Allow us to make the pass renderer fail during pillar rendering when a secret corresponding with a pass path cannot be fetched. For this we add a master config variable pass_strict_fetch. 2. Allow to have prefix for variables that should be processed with the pass renderer. For this we add a master config variable pass_variable_prefix. 3. Allow us to configure pass' GNUPGHOME and PASSWORD_STORE_DIR environmental variables. For this we add master config variables pass_gnupghome and pass_dir.
Configuration menu - View commit details
-
Copy full SHA for cbb1b68 - Browse repository at this point
Copy the full SHA cbb1b68View commit details -
Configuration menu - View commit details
-
Copy full SHA for b116c6e - Browse repository at this point
Copy the full SHA b116c6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 605e55c - Browse repository at this point
Copy the full SHA 605e55cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f3feec - Browse repository at this point
Copy the full SHA 9f3feecView commit details
Commits on Sep 26, 2022
-
Merge branch 'master' into make-pass-renderer-configurable
Megan Wilhite authoredSep 26, 2022 Configuration menu - View commit details
-
Copy full SHA for 8d7d853 - Browse repository at this point
Copy the full SHA 8d7d853View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.